Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1638088
| From | Kalle Valo <kvalo@qca.qualcomm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] net: wireless: ath: ath9k: remove unnecessary code |
| Date | 2017-05-09 14:30 +0200 |
| Message-ID | <tFcr8-1Fu-25@gated-at.bofh.it> (permalink) |
| References | <tF4MV-4Yx-1@gated-at.bofh.it> <tFbEK-13U-7@gated-at.bofh.it> <tFc7M-1x6-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
"Gustavo A. R. Silva" <garsilva@embeddedor.com> writes: > Hi Kalle, > > Quoting Kalle Valo <kvalo@qca.qualcomm.com>: > >> "Gustavo A. R. Silva" <garsilva@embeddedor.com> writes: >> >>> The name of an array used by itself will always return the array's address. >>> So this test will always evaluate as true. >>> >>> Addresses-Coverity-ID: 1364903 >>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> >>> --- >>> drivers/net/wireless/ath/ath9k/eeprom.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/wireless/ath/ath9k/eeprom.c >>> b/drivers/net/wireless/ath/ath9k/eeprom.c >>> index fb80ec8..5c3bc28 100644 >>> --- a/drivers/net/wireless/ath/ath9k/eeprom.c >>> +++ b/drivers/net/wireless/ath/ath9k/eeprom.c >>> @@ -143,7 +143,7 @@ bool ath9k_hw_nvram_read(struct ath_hw *ah, u32 >>> off, u16 *data) >>> >>> if (ah->eeprom_blob) >>> ret = ath9k_hw_nvram_read_firmware(ah->eeprom_blob, off, data); >>> - else if (pdata && !pdata->use_eeprom && pdata->eeprom_data) >>> + else if (pdata && !pdata->use_eeprom) >>> ret = ath9k_hw_nvram_read_pdata(pdata, off, data); >>> else >>> ret = common->bus_ops->eeprom_read(common, off, data); >> >> The patch may very well be valid (didn't check yet) but the commit log >> is gibberish for me. >> > > Let me correct that and I'll send the patch again. Thanks. Also no need to have that long "net: wireless: ath:" prefix, "ath9k: " or "ath10k: " is enough. -- Kalle Valo
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] net: wireless: ath: ath9k: remove unnecessary code "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-09 06:20 +0200
Re: [PATCH] net: wireless: ath: ath9k: remove unnecessary code Kalle Valo <kvalo@qca.qualcomm.com> - 2017-05-09 13:40 +0200
Re: [PATCH] net: wireless: ath: ath9k: remove unnecessary code "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-09 14:10 +0200
Re: [PATCH] net: wireless: ath: ath9k: remove unnecessary code Kalle Valo <kvalo@qca.qualcomm.com> - 2017-05-09 14:30 +0200
Re: [PATCH] net: wireless: ath: ath9k: remove unnecessary code "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-09 14:40 +0200
csiph-web