Re: [PATCH] wil6210: Replace five seq_puts() calls by seq_putc()

From	Eric Dumazet <eric.dumazet@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] wil6210: Replace five seq_puts() calls by seq_putc()
Date	2017-05-09 14:30 +0200
Message-ID	<tFcr8-1Fu-15@gated-at.bofh.it> (permalink)
References	<tF8dQ-7bU-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2017-05-09 at 09:50 +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 8 May 2017 22:22:04 +0200
> 
> Five single characters (line breaks) should be put into a sequence.
> Thus use the corresponding function "seq_putc".
> 
> This issue was detected by using the Coccinelle software.

There is no _issue_ at all here, only a matter of taste.

printf("\n")  or putchar('\n')  in some slow path is really not that
interesting.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] wil6210: Replace five seq_puts() calls by seq_putc() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-09 10:00 +0200
  Re: [PATCH] wil6210: Replace five seq_puts() calls by seq_putc() Eric Dumazet <eric.dumazet@gmail.com> - 2017-05-09 14:30 +0200

csiph-web