Re: [PATCH 2/2] staging: ccree: Fix initialization of anonymous unions

From	Gilad Ben-Yossef <gilad@benyossef.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] staging: ccree: Fix initialization of anonymous unions
Date	2017-05-09 13:30 +0200
Message-ID	<tFbv4-10r-3@gated-at.bofh.it> (permalink)
References	<tEDWq-4jj-9@gated-at.bofh.it> <tEDWq-4jj-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On Sun, May 7, 2017 at 10:53 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> With gcc 4.1.2:
>
>     drivers/staging/ccree/ssi_hash.c:1990: error: unknown field ‘template_ahash’ specified in initializer
>     drivers/staging/ccree/ssi_hash.c:1991: error: unknown field ‘init’ specified in initializer
>     drivers/staging/ccree/ssi_hash.c:1991: warning: missing braces around initializer
>     drivers/staging/ccree/ssi_hash.c:1991: warning: (near initialization for ‘driver_hash[0].<anonymous>.template_ahash’)
>     drivers/staging/ccree/ssi_hash.c:1992: error: unknown field ‘update’ specified in initializer
>     drivers/staging/ccree/ssi_hash.c:1992: warning: excess elements in union initializer
>     ...
>
> Add missing braces to fix this.
> After this it compiles without warnings with gcc 4.1.2 and 4.9.0.

It seems this bothered Andrew Morton too as he just took in to mm his
own patch for the same issue,

Thanks anyway!
Gilad

-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] staging: ccree: Fix initialization of anonymous unions Geert Uytterhoeven <geert@linux-m68k.org> - 2017-05-08 01:40 +0200
  Re: [PATCH 2/2] staging: ccree: Fix initialization of anonymous unions Arnd Bergmann <arnd@arndb.de> - 2017-05-08 10:00 +0200
  Re: [PATCH 2/2] staging: ccree: Fix initialization of anonymous unions Gilad Ben-Yossef <gilad@benyossef.com> - 2017-05-09 13:30 +0200

csiph-web