Re: [PATCH 4/4] vmbus: Adjust five checks for null pointers

From	Stephen Hemminger <stephen@networkplumber.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] vmbus: Adjust five checks for null pointers
Date	2017-05-11 18:40 +0200
Message-ID	<tFZi9-ha-1@gated-at.bofh.it> (permalink)
References	<tFYYN-ax-9@gated-at.bofh.it> <tFZ8v-dN-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 11 May 2017 18:19:21 +0200
SF Markus Elfring <elfring@users.sourceforge.net> wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 11 May 2017 17:52:38 +0200
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> The script “checkpatch.pl” pointed information out like the following.
> 
> Comparison to NULL could be written …
> 
> Thus fix the affected source code places.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Please don't do these kind of checkpatch "fix ups" on existing code.
The comparison with NULL is fine, doing this is just useless churn.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] VMBus: Adjustments for some function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-11 18:20 +0200
  [PATCH 1/4] vmbus: Improve a size determination in  vmbus_device_create() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-11 18:20 +0200
    Re: [PATCH 1/4] vmbus: Improve a size determination in  vmbus_device_create() Stephen Hemminger <stephen@networkplumber.org> - 2017-05-11 18:40 +0200
      Re: [PATCH 1/4] vmbus: Improve a size determination in  vmbus_device_create() Greg KH <greg@kroah.com> - 2017-05-11 19:50 +0200
  [PATCH 4/4] vmbus: Adjust five checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-11 18:30 +0200
    Re: [PATCH 4/4] vmbus: Adjust five checks for null pointers Stephen Hemminger <stephen@networkplumber.org> - 2017-05-11 18:40 +0200

csiph-web