Re: [PATCH] ARM: remove duplicate 'const' annotations'

From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: remove duplicate 'const' annotations'
Date	2017-05-11 16:50 +0200
Message-ID	<tFXzI-7Av-19@gated-at.bofh.it> (permalink)
References	<tFUVc-5Qu-13@gated-at.bofh.it> <tFUVc-5Qu-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Alexandre Belloni <alexandre.belloni@free-electrons.com> [170511 05:02]:
> On 11/05/2017 at 13:50:16 +0200, Arnd Bergmann wrote:
> > gcc-7 warns about some declarations that are more 'const' than necessary:
> > 
> > arch/arm/mach-at91/pm.c:338:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
> >  static const struct of_device_id const ramc_ids[] __initconst = {
> > arch/arm/mach-bcm/bcm_kona_smc.c:36:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
> >  static const struct of_device_id const bcm_kona_smc_ids[] __initconst = {
> > arch/arm/mach-spear/time.c:207:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
> >  static const struct of_device_id const timer_of_match[] __initconst = {
> > arch/arm/mach-omap2/prm_common.c:714:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
> >  static const struct of_device_id const omap_prcm_dt_match_table[] __initconst = {
> > arch/arm/mach-omap2/vc.c:562:35: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
> >  static const struct i2c_init_data const omap4_i2c_timing_data[] __initconst = {
> > 
> > The ones in arch/arm were apparently all introduced accidentally by one
> > commit that correctly marked a lot of variables as __initconst.
> > 
> > Cc: Nicolas Pitre <nico@linaro.org>
> > Fixes: 19c233b79d1a ("ARM: appropriate __init annotation for const data")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

Acked-by: Tony Lindgren <tony@atomide.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] ARM: remove duplicate 'const' annotations' Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-05-11 14:00 +0200
  Re: [PATCH] ARM: remove duplicate 'const' annotations' Tony Lindgren <tony@atomide.com> - 2017-05-11 16:50 +0200

csiph-web