Re: [PATCH v3 3/3] arm64: Silence first allocation with CONFIG_ARM64_MODULE_PLTS=y

From	Catalin Marinas <catalin.marinas@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 3/3] arm64: Silence first allocation with CONFIG_ARM64_MODULE_PLTS=y
Date	2017-05-11 16:00 +0200
Message-ID	<tFWNk-70I-29@gated-at.bofh.it> (permalink)
References	(2 earlier) <tD0u6-4zo-11@gated-at.bofh.it> <tDSEa-77p-21@gated-at.bofh.it> <tENM5-2BE-11@gated-at.bofh.it> <tFvk6-6Qp-13@gated-at.bofh.it> <tFyrE-jn-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, May 10, 2017 at 12:55:12PM +0100, Will Deacon wrote:
> On Wed, May 10, 2017 at 09:38:03AM +0100, Catalin Marinas wrote:
> > On Mon, May 08, 2017 at 11:07:24AM +0100, Will Deacon wrote:
> > > On Fri, May 05, 2017 at 02:07:28PM -0700, Florian Fainelli wrote:
> > > > On 05/03/2017 04:18 AM, Will Deacon wrote:
> > > > > On Thu, Apr 27, 2017 at 11:19:02AM -0700, Florian Fainelli wrote:
> > > > >> When CONFIG_ARM64_MODULE_PLTS is enabled, the first allocation using the
> > > > >> module space fails, because the module is too big, and then the module
> > > > >> allocation is attempted from vmalloc space. Silence the first allocation
> > > > >> failure in that case by setting __GFP_NOWARN.
> > > > >>
> > > > >> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > > >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> > > > >> ---
> > > > >>  arch/arm64/kernel/module.c | 7 ++++++-
> > > > >>  1 file changed, 6 insertions(+), 1 deletion(-)
> > > > > 
> > > > > I'm not sure what the merge plan is for these, but the arm64 bit here
> > > > > looks fine to me:
> > > > > 
> > > > > Acked-by: Will Deacon <will.deacon@arm.com>
> > > > 
> > > > Thanks, not sure either, would you or Catalin want to pick this series?
> > > 
> > > We'd need an Ack from Russell on the arch/arm/ part before we could take
> > > this series.
> > 
> > The first patch touches mm/vmalloc.c, so we could also merge the series
> > via akpm's tree. Andrew, do you have any preference?
> 
> Michal Hocko acked that one, so I think we can take the whole series via
> arm64.

OK. I'll send the patches for -rc1.

Thanks.

-- 
Catalin

Thread

[PATCH 0/3 v3] ARM/ARM64: silence large module first time allocation Florian Fainelli <f.fainelli@gmail.com> - 2017-04-27 20:20 +0200
  [PATCH v3 1/3] mm: Silence vmap() allocation failures based on caller gfp_flags Florian Fainelli <f.fainelli@gmail.com> - 2017-04-27 20:30 +0200
  [PATCH v3 3/3] arm64: Silence first allocation with CONFIG_ARM64_MODULE_PLTS=y Florian Fainelli <f.fainelli@gmail.com> - 2017-04-27 20:30 +0200
    Re: [PATCH v3 3/3] arm64: Silence first allocation with  CONFIG_ARM64_MODULE_PLTS=y Will Deacon <will.deacon@arm.com> - 2017-05-03 13:20 +0200
      Re: [PATCH v3 3/3] arm64: Silence first allocation with  CONFIG_ARM64_MODULE_PLTS=y Florian Fainelli <f.fainelli@gmail.com> - 2017-05-05 23:10 +0200
        Re: [PATCH v3 3/3] arm64: Silence first allocation with  CONFIG_ARM64_MODULE_PLTS=y Will Deacon <will.deacon@arm.com> - 2017-05-08 12:10 +0200
          Re: [PATCH v3 3/3] arm64: Silence first allocation with  CONFIG_ARM64_MODULE_PLTS=y Catalin Marinas <catalin.marinas@arm.com> - 2017-05-10 10:40 +0200
            Re: [PATCH v3 3/3] arm64: Silence first allocation with  CONFIG_ARM64_MODULE_PLTS=y Will Deacon <will.deacon@arm.com> - 2017-05-10 14:00 +0200
              Re: [PATCH v3 3/3] arm64: Silence first allocation with  CONFIG_ARM64_MODULE_PLTS=y Catalin Marinas <catalin.marinas@arm.com> - 2017-05-11 16:00 +0200
  Re: [PATCH 0/3 v3] ARM/ARM64: silence large module first time allocation Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-04-27 20:30 +0200
    Re: [PATCH 0/3 v3] ARM/ARM64: silence large module first time  allocation Florian Fainelli <f.fainelli@gmail.com> - 2017-04-27 20:40 +0200
  [PATCH v3 2/3] ARM: Silence first allocation with CONFIG_ARM_MODULE_PLTS=y Florian Fainelli <f.fainelli@gmail.com> - 2017-04-27 20:30 +0200
    Re: [PATCH v3 2/3] ARM: Silence first allocation with  CONFIG_ARM_MODULE_PLTS=y Florian Fainelli <f.fainelli@gmail.com> - 2017-05-10 01:20 +0200
      Re: [PATCH v3 2/3] ARM: Silence first allocation with  CONFIG_ARM_MODULE_PLTS=y Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-05-10 01:30 +0200

csiph-web