Re: [PATCH] target/iscsi: make function target_parse_xcopy_cmd static

From	Bart Van Assche <Bart.VanAssche@sandisk.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] target/iscsi: make function target_parse_xcopy_cmd static
Date	2017-05-11 16:00 +0200
Message-ID	<tFWNj-70I-7@gated-at.bofh.it> (permalink)
References	<tFTmq-51L-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2017-05-11 at 11:16 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Making target_parse_xcopy_cmd static fixes sparse warning:
> 
> "warning: symbol 'target_parse_xcopy_cmd' was not declared.  Should
> it be static?"
> 
> Fixes: 1bd05294519f76 ("target/iscsi: Fix a deadlock between the XCOPY code and session shutdown")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/target/target_core_xcopy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/target/target_core_xcopy.c b/drivers/target/target_core_xcopy.c
> index aecb36d955f0..00e0269e6be4 100644
> --- a/drivers/target/target_core_xcopy.c
> +++ b/drivers/target/target_core_xcopy.c
> @@ -886,7 +886,7 @@ static void target_xcopy_do_work(struct work_struct *work)
>   * Returns TCM_NO_SENSE upon success or a sense code != TCM_NO_SENSE if parsing
>   * fails.
>   */
> -sense_reason_t target_parse_xcopy_cmd(struct xcopy_op *xop)
> +static sense_reason_t target_parse_xcopy_cmd(struct xcopy_op *xop)
>  {
>  	struct se_cmd *se_cmd = xop->xop_se_cmd;
>  	unsigned char *p = NULL, *seg_desc;

Hello Colin,

Thanks for the patch. I will merge it in patch "target/iscsi: Fix a deadlock between the
XCOPY code and session shutdown".

Bart.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] target/iscsi: make function target_parse_xcopy_cmd static Colin King <colin.king@canonical.com> - 2017-05-11 12:20 +0200
  Re: [PATCH] target/iscsi: make function target_parse_xcopy_cmd static Colin Ian King <colin.king@canonical.com> - 2017-05-11 16:00 +0200
  Re: [PATCH] target/iscsi: make function target_parse_xcopy_cmd static Bart Van Assche <Bart.VanAssche@sandisk.com> - 2017-05-11 16:00 +0200

csiph-web