[PATCH 1/2] of: remove extraneous 'const' in typedef

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	[PATCH 1/2] of: remove extraneous 'const' in typedef
Date	2017-05-11 14:30 +0200
Message-ID	<tFVod-6fr-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

One change that was meant to address a sparse warning turned out
to cause hundreds of new gcc-7 warnings:

include/linux/of_irq.h:11:13: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]

After reverting the change, the gcc warnings are gone again, and I
can't reproduce the sparse warnings either.

Fixes: 17a70355ea57 ("of: fix sparse warnings in fdt, irq, reserved mem, and resolver code")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 include/linux/of_irq.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/of_irq.h b/include/linux/of_irq.h
index ec6b11deb773..1e0deb8e8494 100644
--- a/include/linux/of_irq.h
+++ b/include/linux/of_irq.h
@@ -8,7 +8,7 @@
 #include <linux/ioport.h>
 #include <linux/of.h>
 
-typedef int const (*of_irq_init_cb_t)(struct device_node *, struct device_node *);
+typedef int (*of_irq_init_cb_t)(struct device_node *, struct device_node *);
 
 /*
  * Workarounds only applied to 32bit powermac machines
-- 
2.9.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] of: remove extraneous 'const' in typedef Arnd Bergmann <arnd@arndb.de> - 2017-05-11 14:30 +0200
  Re: [PATCH 1/2] of: remove extraneous 'const' in typedef Rob Herring <robh+dt@kernel.org> - 2017-05-11 16:50 +0200
    Re: [PATCH 1/2] of: remove extraneous 'const' in typedef Arnd Bergmann <arnd@arndb.de> - 2017-05-11 17:10 +0200
      Re: [PATCH 1/2] of: remove extraneous 'const' in typedef Rob Herring <robh+dt@kernel.org> - 2017-05-11 17:20 +0200

csiph-web