Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1639334
| Path | csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Arnd Bergmann <arnd@arndb.de> |
| Newsgroups | linux.kernel |
| Subject | [PATCH] wlcore: fix 64K page support |
| Date | Thu, 11 May 2017 14:00:02 +0200 |
| Message-ID | <tFUVc-5Qu-9@gated-at.bofh.it> (permalink) |
| X-Mailer | git-send-email 2.9.0 |
| X-Provags-ID | V03:K0:kEF+9LlPTtfEQea305v9R9+9psnq/ZIDtfYRb66kjkHkoHEcxeR 626wV4aThXAwFVssknpx0ij7dfsj1yzcM9p/LNKCIuoob0qHSRkULEio5IefU5Ye7bCDsdd NVlehY3vWqY9hh1vq7sJo2t8NAnYN9VHbBb0rKQuB/yLaEssTVSHAlmwBHUrwq1ygYEyRFx 1TaFQZuS8CE23YEWK8fkQ== |
| X-Ui-Out-Filterresults | notjunk:1;V01:K0:wpvhRVM39L0=:/QS6L5/+v5kW2PwtzDFl9H UwXiXwupzIBdOFTxIpHYGy+O/3L0KoRo2nIx57K1QhuJEb5kL4ZDhwo2SvxyDkBT3nIBeMSJq KR4FpfTpNb3C1J0AZYTj7o020klnb1ao/cNh5kJKNwunHf0tNxCkeL58KG+go+VkCCX5AuLDu EhBUlufm6BNYR4KEvZsS2JvgouC4BryYY2H43ArMndIFZiJ6RXmBviSaLT+eAoehVkVc6QWT/ bYrhxsYCMNenyYtSnd/n2iX3Xo9ya3hQZxR9VDX1nAPmi7puQ8j5nXk9ZCOwXjr8UWCj1XASS uxM1z53ZrazAUI28d2M4+n8j6oe8gI+2QAwItho9ghamLlvk7cw6P3xalMIOtn3zbxSXOcHnS pyi5kIjMdB9GKfZEbYTwtCR/kL4rScckgtc0wJtRiQksFn4hSqwS0fdNuEPBLlRSbGke4KPQB hkBn7BR+dN85Z9Cf05KGFA47EjqbtcLdwxVgvdFdGTlIQ1fiU3/cBwKmfe56nt7Nd9X5cs3DR Xo/1YPGoVuvnjlXRM0+soN8IKbqLpunK3WNrmrA7aGXTgzkaszs6xONEJpXpTGC8vfRccfW2i E3Cqim9H6+p55aEh+EkNtCST7wmgqOJHaad9VuqR2iIY9NqJbDwRy1RuavC3A8DmgFqRbsVCZ AlSLrBOrczQO9tKpOjrOuo2wM558q6LqDn/mDyrbUKb2FwmRJuw7NmvKqxAkXbazuhmQ= |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 39 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Arnd Bergmann <arnd@arndb.de>, stable@vger.kernel.org, "Reizer, Eyal" <eyalr@ti.com>, Tony Lindgren <tony@atomide.com>, Wei Yongjun <weiyj.lk@gmail.com>, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Thu, 11 May 2017 13:52:09 +0200 |
| X-Original-Message-ID | <20170511115307.3060650-1-arnd@arndb.de> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1639334 |
Show key headers only | View raw
In the stable linux-3.16 branch, I ran into a warning in the wlcore driver: drivers/net/wireless/ti/wlcore/spi.c: In function 'wl12xx_spi_raw_write': drivers/net/wireless/ti/wlcore/spi.c:315:1: error: the frame size of 12848 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] Newer kernels no longer show the warning, but the bug is still there, as the allocation is based on the CPU page size rather than the actual capabilities of the hardware. This replaces the PAGE_SIZE macro with the SZ_4K macro, i.e. 4096 bytes per buffer. Cc: stable@vger.kernel.org Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/net/wireless/ti/wlcore/spi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ti/wlcore/spi.c b/drivers/net/wireless/ti/wlcore/spi.c index f949ad2bd898..fa3547e06424 100644 --- a/drivers/net/wireless/ti/wlcore/spi.c +++ b/drivers/net/wireless/ti/wlcore/spi.c @@ -70,10 +70,10 @@ #define WSPI_MAX_CHUNK_SIZE 4092 /* - * wl18xx driver aggregation buffer size is (13 * PAGE_SIZE) compared to - * (4 * PAGE_SIZE) for wl12xx, so use the larger buffer needed for wl18xx + * wl18xx driver aggregation buffer size is (13 * 4K) compared to + * (4 * 4K) for wl12xx, so use the larger buffer needed for wl18xx */ -#define SPI_AGGR_BUFFER_SIZE (13 * PAGE_SIZE) +#define SPI_AGGR_BUFFER_SIZE (13 * SZ_4K) /* Maximum number of SPI write chunks */ #define WSPI_MAX_NUM_OF_CHUNKS \ -- 2.9.0
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH] wlcore: fix 64K page support Arnd Bergmann <arnd@arndb.de> - 2017-05-11 14:00 +0200
csiph-web