Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1639287

Re: [PATCH v7 3/5] test: add new driver_data load tester

Show all headers | View raw

Luis,

On Tue, May 02, 2017 at 01:49:12AM -0700, Luis R. Rodriguez wrote:
> 
> diff --git a/lib/test_driver_data.c b/lib/test_driver_data.c
> new file mode 100644
> index 000000000000..488cc6e9eed4
> --- /dev/null
> +++ b/lib/test_driver_data.c

  ...

> +static int trigger_config_sync(struct driver_data_test_device *test_dev)
> +{
> +	struct test_config *config = &test_dev->config;
> +	int ret;
> +	const struct driver_data_req_params req_params_default = {
> +		DRIVER_DATA_DEFAULT_SYNC_REQS(config_sync_req_cb, test_dev,
> +					      DRIVER_DATA_REQ_OPTIONAL |
> +					      DRIVER_DATA_REQ_KEEP)

Are these flags always on?

> +void free_test_dev_driver_data(struct driver_data_test_device *test_dev)
> +{
> +	kfree_const(test_dev->misc_dev.name);
> +	test_dev->misc_dev.name = NULL;
> +	vfree(test_dev);
> +	test_dev = NULL;
> +	driver_data_config_free(test_dev);

Removing this test module fails.

The last three lines should be:
	driver_data_config_free(test_dev);
	vfree(test_dev);

> +}
> +
> +void unregister_test_dev_driver_data(struct driver_data_test_device *test_dev)
> +{
> +	wait_for_completion_timeout(&test_dev->request_complete, 5 * HZ);
> +	dev_info(test_dev->dev, "removing interface\n");
> +	misc_deregister(&test_dev->misc_dev);
> +	kfree(&test_dev->misc_dev.name);

Don't need this kfree().

Thanks,
-Takahiro AKASHI

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v7 0/5] firmware: add driver data API "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-05-02 11:00 +0200
  [PATCH v7 1/5] firmware: add extensible driver data params "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-05-02 11:00 +0200
    Re: [PATCH v7 1/5] firmware: add extensible driver data params "Li, Yi" <yi1.li@linux.intel.com> - 2017-05-11 20:20 +0200
      Re: [PATCH v7 1/5] firmware: add extensible driver data params "Luis R. Rodriguez" <mcgrof@suse.com> - 2017-05-11 20:30 +0200
  [PATCH v7 2/5] firmware: add extensible driver data API "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-05-02 11:00 +0200
  [PATCH v7 5/5] iwlwifi: convert to use driver data API "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-05-02 11:00 +0200
  [PATCH v7 4/5] firmware: document the extensible driver data API "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-05-02 11:00 +0200
  Re: [PATCH v7 3/5] test: add new driver_data load tester AKASHI Takahiro <takahiro.akashi@linaro.org> - 2017-05-11 12:10 +0200
    Re: [PATCH v7 3/5] test: add new driver_data load tester "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-05-11 19:10 +0200

csiph-web