Re: [RFC GIT PULL, v2] RCU changes for v4.12

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFC GIT PULL, v2] RCU changes for v4.12
Date	2017-05-11 09:00 +0200
Message-ID	<tFQeR-2Vn-3@gated-at.bofh.it> (permalink)
References	<tCghA-7tr-3@gated-at.bofh.it> <tF7KN-6Yd-15@gated-at.bofh.it> <tFDB0-3wL-1@gated-at.bofh.it> <tFFW9-4OQ-7@gated-at.bofh.it> <tFG5Q-58x-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Wed, May 10, 2017 at 12:54 PM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > Yeah, you are right and sorry about that - I have removed the patch
> > generation from my pull request scripts, so it shouldn't happen in
> > the future.
> 
> I do have to say, that during the later -rc series in particular when
> people send me smaller fixes, I enjoy seeing the full patches.

I find them useful too, and to answer your original question:

> > Nobody is ever going to review a 300kB patch that is ~7500 lines.

I _did_ skim over that 300K patch, because I always try to do a final manual check 
on the raw diffs I'm sending to you, and also to make it very clear what was sent 
from a full disclosure and security log POV, independent of the Git pull space. 

When patches are way too long, for example as the perf pull request diffs often 
are, I trim them, so it's never an absolute, script-only thing.

Still it's not an excuse:

 - I doubt anyone else but me would skim over a 30K (let alone a 300K) patch,

 - I also missed the pain large patches cause in Gmail replies (with Mutt that
   pain is considerably less),

 - plus, most importantly, I didn't notice that the extra RCU mode bloat was one 
   too many in an already sizable line-up of RCU complexity ...

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC GIT PULL, v2] RCU changes for v4.12 Linus Torvalds <torvalds@linux-foundation.org> - 2017-05-10 19:30 +0200
  Re: [RFC GIT PULL, v2] RCU changes for v4.12 "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-05-10 22:00 +0200
    Re: [RFC GIT PULL, v2] RCU changes for v4.12 Linus Torvalds <torvalds@linux-foundation.org> - 2017-05-10 22:20 +0200
      Re: [RFC GIT PULL, v2] RCU changes for v4.12 "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-05-10 23:00 +0200
        Re: [RFC GIT PULL, v2] RCU changes for v4.12 Linus Torvalds <torvalds@linux-foundation.org> - 2017-05-10 23:10 +0200
          Re: [RFC GIT PULL, v2] RCU changes for v4.12 "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-05-11 01:00 +0200
  Re: [RFC GIT PULL, v2] RCU changes for v4.12 Ingo Molnar <mingo@kernel.org> - 2017-05-10 22:00 +0200
    Re: [RFC GIT PULL, v2] RCU changes for v4.12 Linus Torvalds <torvalds@linux-foundation.org> - 2017-05-10 22:10 +0200
      Re: [RFC GIT PULL, v2] RCU changes for v4.12 Ingo Molnar <mingo@kernel.org> - 2017-05-11 09:00 +0200

csiph-web