Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1639174
| From | Kalle Valo <kvalo@codeaurora.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] libertas: Avoid reading past end of buffer |
| Date | 2017-05-11 05:50 +0200 |
| Message-ID | <tFNgZ-11V-5@gated-at.bofh.it> (permalink) |
| References | <tFFt8-4EF-3@gated-at.bofh.it> <tFIU2-6SG-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Joe Perches <joe@perches.com> writes: > unrelated trivia: > > lbs_deb_enter is used incorrectly here at > function exit as both enter and leave calls. > > That type of copy/paste defect may be common. > > $ git grep -w lbs_deb_enter | wc -l > 148 > $ git grep -w lbs_deb_leave | wc -l > 71 > > One would expect these numbers to be the same. > > Another option would be to delete all these > calls as ftrace function tracing works well. Yeah, deleting all the enter/exit calls would be better. -- Kalle Valo
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] libertas: Avoid reading past end of buffer Kees Cook <keescook@chromium.org> - 2017-05-10 21:30 +0200
Re: [PATCH] libertas: Avoid reading past end of buffer Joe Perches <joe@perches.com> - 2017-05-11 01:10 +0200
Re: [PATCH] libertas: Avoid reading past end of buffer Kalle Valo <kvalo@codeaurora.org> - 2017-05-11 05:50 +0200
Re: [PATCH] libertas: Avoid reading past end of buffer Joe Perches <joe@perches.com> - 2017-05-11 01:20 +0200
csiph-web