Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1639185

Re: [PATCH] FS: Making aproriate return type

From Al Viro <viro@ZenIV.linux.org.uk>
Newsgroups linux.kernel
Subject Re: [PATCH] FS: Making aproriate return type
Date 2017-05-11 06:30 +0200
Message-ID <tFNTH-1w1-7@gated-at.bofh.it> (permalink)
References <tFNK1-1q6-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, May 11, 2017 at 09:44:09AM +0530, Pushkar Jambhlekar wrote:
> unsigned_offsets function returns fmode_t but function definition returns int. sparse generate warning.
> Updating proper return type

You do realize that it's a predicate?  This is actually one case where
bool would be appropriate...

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] FS: Making aproriate return type Pushkar Jambhlekar <pushkar.iit@gmail.com> - 2017-05-11 06:20 +0200
  Re: [PATCH] FS: Making aproriate return type Al Viro <viro@ZenIV.linux.org.uk> - 2017-05-11 06:30 +0200

csiph-web