Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1639181

Re: [RFC 07/10] fscrypt: move to generic async completion

Show all headers | View raw

Hi Gilad,

On Sat, May 06, 2017 at 03:59:56PM +0300, Gilad Ben-Yossef wrote:
>  int fscrypt_do_page_crypto(const struct inode *inode, fscrypt_direction_t rw,
>  			   u64 lblk_num, struct page *src_page,
>  			   struct page *dest_page, unsigned int len,
> @@ -150,7 +135,7 @@ int fscrypt_do_page_crypto(const struct inode *inode, fscrypt_direction_t rw,
>  		u8 padding[FS_XTS_TWEAK_SIZE - sizeof(__le64)];
>  	} xts_tweak;
>  	struct skcipher_request *req = NULL;
> -	DECLARE_FS_COMPLETION_RESULT(ecr);
> +	DECLARE_CRYPTO_WAIT(ecr);
>  	struct scatterlist dst, src;
>  	struct fscrypt_info *ci = inode->i_crypt_info;
>  	struct crypto_skcipher *tfm = ci->ci_ctfm;
> @@ -168,7 +153,7 @@ int fscrypt_do_page_crypto(const struct inode *inode, fscrypt_direction_t rw,
[...]

This patch looks good --- thanks for doing this!  I suggest also renaming 'ecr'
to 'wait' in the places being updated to use crypto_wait, since the name is
obsolete (and was already; it originally stood for "ext4 completion result").

- Eric

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC 00/10] introduce crypto wait for async op function Gilad Ben-Yossef <gilad@benyossef.com> - 2017-05-06 15:10 +0200
  [RFC 10/10] crypto: adapt api sample to use async. op wait Gilad Ben-Yossef <gilad@benyossef.com> - 2017-05-06 15:10 +0200
  [RFC 03/10] crypto: move drbg to generic async completion Gilad Ben-Yossef <gilad@benyossef.com> - 2017-05-06 15:10 +0200
  [RFC 07/10] fscrypt: move to generic async completion Gilad Ben-Yossef <gilad@benyossef.com> - 2017-05-06 15:10 +0200
    Re: [RFC 07/10] fscrypt: move to generic async completion Eric Biggers <ebiggers3@gmail.com> - 2017-05-11 06:10 +0200
  [RFC 05/10] crypto: move testmgr to generic async completion Gilad Ben-Yossef <gilad@benyossef.com> - 2017-05-06 15:10 +0200
  [RFC 09/10] ima: move to generic async completion Gilad Ben-Yossef <gilad@benyossef.com> - 2017-05-06 15:10 +0200
    Re: [RFC 09/10] ima: move to generic async completion Mimi Zohar <zohar@linux.vnet.ibm.com> - 2017-05-10 23:30 +0200
  [RFC 02/10] crypto: move pub key to generic async completion Gilad Ben-Yossef <gilad@benyossef.com> - 2017-05-06 15:10 +0200
  [RFC 06/10] dm: move dm-verity to generic async completion Gilad Ben-Yossef <gilad@benyossef.com> - 2017-05-06 15:10 +0200
  [RFC 08/10] cifs: move to generic async completion Gilad Ben-Yossef <gilad@benyossef.com> - 2017-05-06 15:10 +0200
    Re: [RFC 08/10] cifs: move to generic async completion Pavel Shilovsky <pshilovsky@samba.org> - 2017-05-08 23:00 +0200

csiph-web