Re: [PATCH] irqchip/bcm2836: Move SMP startup code to arch/arm

From	Phil Elwell <phil@raspberrypi.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] irqchip/bcm2836: Move SMP startup code to arch/arm
Date	2017-05-10 17:40 +0200
Message-ID	<tFBSx-2s3-7@gated-at.bofh.it> (permalink)
References	<tFzQJ-1g0-1@gated-at.bofh.it> <tFA0r-1j1-39@gated-at.bofh.it> <tFBpv-2iN-1@gated-at.bofh.it> <tFBSx-2s3-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10/05/2017 16:31, Marc Zyngier wrote:
> On 10/05/17 16:07, Phil Elwell wrote:
>> On 10/05/2017 14:32, Marc Zyngier wrote:
>>> On 10/05/17 14:26, Marc Zyngier wrote:
>>>> One of the RPi-2/3 irqchip's key features is that it contains some
>>>> SMP startup code for the 32bit ARM architecture version. The only
>>>> reason I can imagine for this is "RPi is special".
>>>>
>>>> Let's move this code where it belongs (in the platform support code),
>>>> creating a shared include file for this purpose.
>>>>
>>>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>>>
>>> Also:
>>> Fixes: 41f4988cc287 ("irqchip/bcm2836: Add SMP support for the 2836")
>>>
>>> 	M.
>>>
>>
>> The patch has some checkpatch warnings, but otherwise:
> 
> Bah...
> 
> WARNING: line over 80 characters
> #51: FILE: arch/arm/mach-bcm/board_bcm2835.c:30:
> +static int bcm2836_smp_boot_secondary(unsigned int cpu, struct task_struct *idle)
> 
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #194: 
> new file mode 100644
> 
> Yup, the checkpatch stamp of approval. My screen has stopped being 
> limited to 80 chars at some point between 1989 and 1991. As for the
> MAINTAINERS file, that's probably for the maintainers to pick it up.
> 
>> Reviewed-by: Phil Elwell <phil@raspberrypi.org>
>> Tested-by: Phil Elwell <phil@raspberrypi.org>
> 
> Thanks. I assume you'll respin your DSB/SEV fix on top of this?

Yes - how does one manage the timing of interdependent patches?

Phil

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] irqchip/bcm2836: Move SMP startup code to arch/arm Marc Zyngier <marc.zyngier@arm.com> - 2017-05-10 15:30 +0200
  Re: [PATCH] irqchip/bcm2836: Move SMP startup code to arch/arm Marc Zyngier <marc.zyngier@arm.com> - 2017-05-10 15:40 +0200
    Re: [PATCH] irqchip/bcm2836: Move SMP startup code to arch/arm Phil Elwell <phil@raspberrypi.org> - 2017-05-10 17:10 +0200
      Re: [PATCH] irqchip/bcm2836: Move SMP startup code to arch/arm Marc Zyngier <marc.zyngier@arm.com> - 2017-05-10 17:40 +0200
        Re: [PATCH] irqchip/bcm2836: Move SMP startup code to arch/arm Stefan Wahren <stefan.wahren@i2se.com> - 2017-05-10 18:00 +0200
          Re: [PATCH] irqchip/bcm2836: Move SMP startup code to arch/arm Marc Zyngier <marc.zyngier@arm.com> - 2017-05-10 18:10 +0200
      Re: [PATCH] irqchip/bcm2836: Move SMP startup code to arch/arm Marc Zyngier <marc.zyngier@arm.com> - 2017-05-10 17:40 +0200
        Re: [PATCH] irqchip/bcm2836: Move SMP startup code to arch/arm Phil Elwell <phil@raspberrypi.org> - 2017-05-10 17:40 +0200

csiph-web