Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1637994

Re: [PATCH] perf, tools: Support srccode output

From Jiri Olsa <jolsa@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH] perf, tools: Support srccode output
Date 2017-05-09 11:10 +0200
Message-ID <tF9jz-89r-9@gated-at.bofh.it> (permalink)
References <tEXs5-cz-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, May 08, 2017 at 01:22:05PM -0700, Andi Kleen wrote:

SNIP

> diff --git a/tools/perf/util/srcline.c b/tools/perf/util/srcline.c
> index df051a52393c..542bfa7db53c 100644
> --- a/tools/perf/util/srcline.c
> +++ b/tools/perf/util/srcline.c
> @@ -479,6 +479,35 @@ char *__get_srcline(struct dso *dso, u64 addr, struct symbol *sym,
>  	return srcline;
>  }
>  
> +/* Returns filename and fills in line number in line */
> +char *get_srcline_split(struct dso *dso, u64 addr,
> +			bool unwind_inlines, unsigned *line)

no need to pass unwind_inlines as arg if it's always true

jirka

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] perf, tools: Support srccode output Andi Kleen <andi@firstfloor.org> - 2017-05-08 22:30 +0200
  Re: [PATCH] perf, tools: Support srccode output Jiri Olsa <jolsa@redhat.com> - 2017-05-09 11:10 +0200
  Re: [PATCH] perf, tools: Support srccode output Jiri Olsa <jolsa@redhat.com> - 2017-05-09 11:10 +0200

csiph-web