Re: [PATCH] staging : rtl8188eu : remove unnecessary else

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging : rtl8188eu : remove unnecessary else
Date	2017-05-09 10:10 +0200
Message-ID	<tF8nv-7up-1@gated-at.bofh.it> (permalink)
References	<tEMwG-1z9-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, May 08, 2017 at 02:13:00PM +0530, Surender Polsani wrote:
> according to coding style else is not generally
> useful after a break or return
> 
> Signed-off-by: Surender Polsani <surenderpolsani@gmail.com>
> ---
>  drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
> index d04b7fb..7420f55 100644
> --- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
> +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
> @@ -212,8 +212,7 @@ u8 rtw_hal_antdiv_before_linked(struct adapter *Adapter)
>  
>  		rtw_antenna_select_cmd(Adapter, dm_swat_tbl->CurAntenna, false);
>  		return true;
> -	} else {
> +	}
>  		dm_swat_tbl->SWAS_NoLink_State = 0;
>  		return false;
> -	}

Nope.

I think you really need to learn C programming before you send any more
patches.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging : rtl8188eu : remove unnecessary else Surender Polsani <surenderpolsani@gmail.com> - 2017-05-08 10:50 +0200
  Re: [PATCH] staging : rtl8188eu : remove unnecessary else Joe Perches <joe@perches.com> - 2017-05-08 21:50 +0200
  Re: [PATCH] staging : rtl8188eu : remove unnecessary else Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-09 10:10 +0200

csiph-web