Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1637945
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/3] staging: iio: meter: Add the comment for mutex definition |
| Date | 2017-05-09 09:50 +0200 |
| Message-ID | <tF84a-77W-27@gated-at.bofh.it> (permalink) |
| References | <tF2rL-3nF-5@gated-at.bofh.it> <tF2Br-3r8-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, May 08, 2017 at 10:00:37PM -0400, Harinath Nampally wrote:
> This patch fixes below checkpatch.pl warning:
> CHECK: struct mutex definition without comment
>
> Signed-off-by: Harinath Nampally <harinath922@gmail.com>
> ---
> drivers/staging/iio/meter/ade7753.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/meter/ade7753.c b/drivers/staging/iio/meter/ade7753.c
> index b71fbd3..cffe6bf 100644
> --- a/drivers/staging/iio/meter/ade7753.c
> +++ b/drivers/staging/iio/meter/ade7753.c
> @@ -78,12 +78,13 @@
> /**
> * struct ade7753_state - device instance specific data
> * @us: actual spi_device
> + * @buf_lock: mutex to protect tx and rx
> * @tx: transmit buffer
> * @rx: receive buffer
> - * @buf_lock: mutex to protect tx and rx
> **/
> struct ade7753_state {
> struct spi_device *us;
> + /* mutex to protect tx and rx */
Not aligned. We don't need two duplicate comments anyway.
> struct mutex buf_lock;
regards,
dan carpenter
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/3] coding style warnings fixes Harinath Nampally <harinath922@gmail.com> - 2017-05-09 04:00 +0200
[PATCH 1/3] staging: iio: meter: Add the comment for mutex definition Harinath Nampally <harinath922@gmail.com> - 2017-05-09 04:00 +0200
Re: [PATCH 1/3] staging: iio: meter: Add the comment for mutex definition Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-09 09:50 +0200
[PATCH v2 1/3] staging: iio: meter: Add the comment for mutex definition. Harinath Nampally <harinath922@gmail.com> - 2017-05-10 01:50 +0200
[PATCH v2 3/3] staging: iio: meter: Replace symbolic permissions with octal permissions. Harinath Nampally <harinath922@gmail.com> - 2017-05-10 01:50 +0200
[PATCH v2 0/3] coding style warnings fixes Harinath Nampally <harinath922@gmail.com> - 2017-05-10 01:50 +0200
[PATCH v2 2/3] staging: iio: meter: Fix the identations for proper alignments. Harinath Nampally <harinath922@gmail.com> - 2017-05-10 01:50 +0200
csiph-web