Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1637912

Re: [PATCH] Fix NR_IRQS printk()

Show all headers | View raw

On Wed, 3 May 2017, Vincent Legoll wrote:

> Subject : [PATCH] Fix NR_IRQS printk()

The subject line is missing a subsystem token. Please consult

  Documentation/process/submitting-patches.rst

and run 'git log path/to/affected.file' to see how a proper subject line
should look like.

> - Missing some whitespace
> - Tell that the third number is "initcnt" (whatever that is)

Your changelog is telling WHAT the patch is doing, but not WHY and despite
the subject claiming to fix something the changelog lacks any information
about the problem it "fixes".

Aside of that: "(whatever that is)" is not really convincing that you know
what you are doing.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Fix NR_IRQS printk() Vincent Legoll <vincent.legoll@gmail.com> - 2017-05-03 12:10 +0200
  Re: [PATCH] Fix NR_IRQS printk() Thomas Gleixner <tglx@linutronix.de> - 2017-05-09 09:10 +0200
    Re: [PATCH] Fix NR_IRQS printk() Vincent Legoll <vincent.legoll@gmail.com> - 2017-05-09 09:50 +0200
      [PATCH] genirq: Tell that early_irq_init() is printing the nr of preallocated irqs Vincent Legoll <vincent.legoll@gmail.com> - 2017-05-09 10:30 +0200
        [PATCH] genirq: Tell that early_irq_init() is printing the nr of preallocated irqs Vincent Legoll <vincent.legoll@gmail.com> - 2017-05-09 10:40 +0200

csiph-web