Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1637910

Re: [PATCH] qca_debug: Reduce function calls for sequence output in qcaspi_info_show()

Show all headers | View raw

Am 08.05.2017 um 19:29 schrieb SF Markus Elfring:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 8 May 2017 19:21:27 +0200
>
> A bit of data was put into a sequence by separate function calls.
> Print the same data together with adjusted seq_printf() calls instead.

Sorry, i'm not happy with this patch. It doesn't increase readabilityand
mixes the output of multiple lines.

The only benefit is a little bit higher performance. But for debugfs
this won't be necessary.

Stefan

>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/net/ethernet/qualcomm/qca_debug.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] qca_debug: Reduce function calls for sequence output in  qcaspi_info_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-08 19:40 +0200
  Re: [PATCH] qca_debug: Reduce function calls for sequence output in  qcaspi_info_show() Stefan Wahren <stefan.wahren@i2se.com> - 2017-05-09 09:10 +0200
    Re: qca_debug: Reduce function calls for sequence output in  qcaspi_info_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-09 10:00 +0200

csiph-web