Re: [PATCH] sched/fair: WARN and refuse to set buddy when !se->on_rq

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] sched/fair: WARN and refuse to set buddy when !se->on_rq
Date	2017-05-09 08:50 +0200
Message-ID	<tF786-6qs-9@gated-at.bofh.it> (permalink)
References	<tEWw2-84h-11@gated-at.bofh.it> <tEWFH-87A-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, May 08, 2017 at 10:32:30PM +0300, Konstantin Khlebnikov wrote:
> On Mon, May 8, 2017 at 10:22 PM, Daniel Axtens <dja@axtens.net> wrote:

> > I recently had to debug a problem with these (we hadn't backported
> > Konstantin's patches in this area) and this would have saved a lot
> > of time/pain.
> 
> Yep, this is worth debug. But I think it should be under compile-time
> config option.
> Something like CONFIG_DEBUG_VM which enables VM_BUG_ON and VM_WARN_ON.

See SCHED_WARN_ON() and feel free to introduce SCHED_WARN_ON_ONCE() if
you feel that's needed.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] sched/fair: WARN and refuse to set buddy when !se->on_rq Daniel Axtens <dja@axtens.net> - 2017-05-08 21:30 +0200
  Re: [PATCH] sched/fair: WARN and refuse to set buddy when !se->on_rq Konstantin Khlebnikov <koct9i@gmail.com> - 2017-05-08 21:40 +0200
    Re: [PATCH] sched/fair: WARN and refuse to set buddy when !se->on_rq Daniel Axtens <dja@axtens.net> - 2017-05-09 03:50 +0200
    Re: [PATCH] sched/fair: WARN and refuse to set buddy when !se->on_rq Peter Zijlstra <peterz@infradead.org> - 2017-05-09 08:50 +0200

csiph-web