Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1637826

Re: [PATCH] scsi: qedf: Avoid reading past end of buffer

From "Martin K. Petersen" <martin.petersen@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH] scsi: qedf: Avoid reading past end of buffer
Date 2017-05-09 04:10 +0200
Message-ID <tF2L8-3JE-1@gated-at.bofh.it> (permalink)
References <tDUcV-80b-7@gated-at.bofh.it>
Organization Oracle Corporation

Show all headers | View raw


Kees,

> Using memcpy() from a string that is shorter than the length copied
> means the destination buffer is being filled with arbitrary data from
> the kernel rodata segment. Instead, use strncpy() which will fill the
> trailing bytes with zeros.

Applied to 4.12/scsi-fixes, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] scsi: qedf: Avoid reading past end of buffer Kees Cook <keescook@chromium.org> - 2017-05-06 00:50 +0200
  Re: [PATCH] scsi: qedf: Avoid reading past end of buffer Bart Van Assche <Bart.VanAssche@sandisk.com> - 2017-05-06 01:10 +0200
    Re: [PATCH] scsi: qedf: Avoid reading past end of buffer Kees Cook <keescook@chromium.org> - 2017-05-06 01:20 +0200
  Re: [PATCH] scsi: qedf: Avoid reading past end of buffer "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-05-09 04:10 +0200

csiph-web