Re: [PATCH v2] sd: Ignore sync cache failures when not supported

From	"Martin K. Petersen" <martin.petersen@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] sd: Ignore sync cache failures when not supported
Date	2017-05-09 04:00 +0200
Message-ID	<tF2Br-3r8-9@gated-at.bofh.it> (permalink)
References	<tDlyy-1Fo-9@gated-at.bofh.it> <tDHpn-877-7@gated-at.bofh.it>
Organization	Oracle Corporation

Show all headers | View raw

Christoph,

> Normally we'd just pass the scsi_sense_hdr structure in from the caler
> if we care about sense data.  Is this something you considered?
>
> Otherwise this looks fine to me.

I agree with Christoph that passing the sense header would be more
consistent with the rest of the SCSI code. Even if we only need the key
in this case.

-- 
Martin K. Petersen	Oracle Linux Engineering

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] sd: Ignore sync cache failures when not supported Thierry Escande <thierry.escande@collabora.com> - 2017-05-04 11:50 +0200
  Re: [PATCH v2] sd: Ignore sync cache failures when not supported Bart Van Assche <Bart.VanAssche@sandisk.com> - 2017-05-04 17:30 +0200
  Re: [PATCH v2] sd: Ignore sync cache failures when not supported Christoph Hellwig <hch@infradead.org> - 2017-05-05 11:10 +0200
    Re: [PATCH v2] sd: Ignore sync cache failures when not supported Thierry Escande <thierry.escande@collabora.com> - 2017-05-05 13:50 +0200
    Re: [PATCH v2] sd: Ignore sync cache failures when not supported "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-05-09 04:00 +0200

csiph-web