Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1637785
| From | Girish Moodalbail <girish.moodalbail@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] drivers: net: wimax: i2400m: i2400m-usb: Use time_after for time comparison |
| Date | 2017-05-09 01:30 +0200 |
| Message-ID | <tF0gh-22h-5@gated-at.bofh.it> (permalink) |
| References | <tEUaS-6rk-9@gated-at.bofh.it> <tEYoa-Pg-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 5/8/17 2:26 PM, David Miller wrote:
> From: Karim Eshapa <karim.eshapa@gmail.com>
> Date: Mon, 8 May 2017 18:58:02 +0200
>
>> diff --git a/drivers/net/wimax/i2400m/i2400m-usb.h b/drivers/net/wimax/i2400m/i2400m-usb.h
>> index 649ecad..6fc941c 100644
>> --- a/drivers/net/wimax/i2400m/i2400m-usb.h
>> +++ b/drivers/net/wimax/i2400m/i2400m-usb.h
>> @@ -131,7 +131,7 @@ static inline int edc_inc(struct edc *edc, u16 max_err, u16 timeframe)
>> unsigned long now;
>>
>> now = jiffies;
>> - if (now - edc->timestart > timeframe) {
>> + if (time_after(now - edc->timestart, (unsigned long)timeframe)) {
>
> This is far from correct.
>
> time_after() compares two "jiffies" timestamp values. The second
> argument here is not a jiffies timestamp value.
>
Perhaps, what is needed here is:
+ if (time_after(jiffies, edc->timestart + timeframe)) {
where in 'timeframe' is set in HZ in all the callers I checked (for the most
part it is set to EDC_ERROR_TIMEFRAME which is 1HZ).
~Girish
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] drivers: net: wimax: i2400m: i2400m-usb: Use time_after for time comparison Karim Eshapa <karim.eshapa@gmail.com> - 2017-05-08 19:00 +0200
Re: [PATCH] drivers: net: wimax: i2400m: i2400m-usb: Use time_after for time comparison David Miller <davem@davemloft.net> - 2017-05-08 23:30 +0200
Re: [PATCH] drivers: net: wimax: i2400m: i2400m-usb: Use time_after for time comparison Girish Moodalbail <girish.moodalbail@oracle.com> - 2017-05-09 01:30 +0200
RE: [PATCH] drivers: net: wimax: i2400m: i2400m-usb: Use time_after for time comparison Karim Eshapa <karim.eshapa@gmail.com> - 2017-05-09 02:10 +0200
Re: [PATCH] drivers: net: wimax: i2400m: i2400m-usb: Use time_after for time comparison David Miller <davem@davemloft.net> - 2017-05-09 15:50 +0200
csiph-web