[PATCH 2/3] kernel-sched: Adjust four checks for null pointers

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	[PATCH 2/3] kernel-sched: Adjust four checks for null pointers
Date	Sat, 06 May 2017 21:50:01 +0200
Message-ID	<tEdSh-3MB-11@gated-at.bofh.it> (permalink)
References	<tEdSh-3MB-3@gated-at.bofh.it>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Language	en-US
Content-Transfer-Encoding	8bit
X-Provags-ID	V03:K0:LVEFOEw9NEloeURK6S4j1d3kmm01Avy5avuz/LrcVBJ2GhURW1A FWBtwKaxEqqErmwUOAyHuuXJ39OSAdZn8KlsKKeR4P4/KZeNr2R6jaLWI3ulZFEBxTYcVtu FFajBaq8/iBMvKUgGutZuFv/+quEr+9zP6Hzqs0YkEe89GXU441yleFi1X/EZsDHhdUyofr TSxg+O+yWHmPtj68AF0Rw==
X-Ui-Out-Filterresults	notjunk:1;V01:K0:lhfIwzBfQEg=:pfNjj+GCxJvfHDwVnSXi9L 3S9Y8NDD7ruYPOpMnRVsmWkJW/Fpd8kI4U5BuPexTU+xNhQ9rIWMe48V97KzYVfOAD5t6SnFf SzROqqyqlqn1r2h/DDdaZgjlXwb6zMDI1h0yTf1ZUDzPeWUCpwiZ+iiuPLgMl6FfqIHOrPEy1 5f9eR6fEN9NvDdIaqXLq27E1nx7jaBH/+TPYYrnQmRjcTLmlS0TV191ySYO+zaq9clyE9m9aT nwITuKcOqtceNwqzZEgSE0+APBFuQRiBagG80ALgu8QdZKr3/aKqKCW1yK8b2wunGj4pPI8Rp SEyJjgMYD05mBNREdCGQtpk8d1MTurIYxbWl8e3+8X8977MLXcj2zG4itR+4A73Ouh7jU6a6O dNXr3+V7euQLUz71ywKYNj7fX7ScmkdgtTmfOiwceK0P8lrTdvuHNgtZ1iJAMrgZa/Q92v107 /LKGAAnRpR1alL5Vbzo5rq4mn7T2ZHxWPPn39kPjIr0H3zRLsnH6zdlam5LFXS33dqX6ciJSZ jAP970PY4zDYP+LAIZuinkrgIh3rih7i3ATXGJX0GLXO+KZjtc5tgGimWYXPCNEYaRjjWGlJU qMyRFHjxFngAz/OZPYK4xa2OUe1PKSLqrw6y7a5xPyp381TWjnhA3mBxgu3a46bTyEKXUt81Y zWx+TLWZBlaSw9UjksD1MN+BVF89M83mAI4U2qbk+UEmkKd2S8tKGN39YswcgF58J0NCMj31d ZPE3Y9oqNG/AAAz0Mi0szcESE1afiZNGtIxMn10pwFEKuxohWngym2Ciw6+YNFYH/7c0P7i7H +LuzWn6
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	59
Organization	linux.* mail to news gateway
X-Original-Cc	LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
X-Original-Date	Sat, 6 May 2017 21:42:50 +0200
X-Original-Message-ID	<15f374e1-e55a-93fb-d475-194c34be41c9@users.sourceforge.net>
X-Original-References	<ece07743-9bbb-e396-b562-ba161c3eb9b8@users.sourceforge.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1636974

Show key headers only | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 6 May 2017 21:17:36 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The script “checkpatch.pl” pointed information out like the following.

Comparison to NULL could be written !…

Thus fix the affected source code place.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 kernel/sched/debug.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
index ff599b7f10b6..4a1abb61d1f7 100644
--- a/kernel/sched/debug.c
+++ b/kernel/sched/debug.c
@@ -231,7 +231,7 @@ static void sd_free_ctl_entry(struct ctl_table **tablep)
 	for (entry = *tablep; entry->mode; entry++) {
 		if (entry->child)
 			sd_free_ctl_entry(&entry->child);
-		if (entry->proc_handler == NULL)
+		if (!entry->proc_handler)
 			kfree(entry->procname);
 	}
 
@@ -265,7 +265,7 @@ sd_alloc_ctl_domain_table(struct sched_domain *sd)
 {
 	struct ctl_table *table = sd_alloc_ctl_entry(14);
 
-	if (table == NULL)
+	if (!table)
 		return NULL;
 
 	set_table_entry(&table[0], "min_interval", &sd->min_interval,
@@ -311,7 +311,7 @@ static struct ctl_table *sd_alloc_ctl_cpu_table(int cpu)
 	for_each_domain(cpu, sd)
 		domain_num++;
 	entry = table = sd_alloc_ctl_entry(domain_num + 1);
-	if (table == NULL)
+	if (!table)
 		return NULL;
 
 	i = 0;
@@ -336,7 +336,7 @@ void register_sched_domain_sysctl(void)
 	WARN_ON(sd_ctl_dir[0].child);
 	sd_ctl_dir[0].child = entry;
 
-	if (entry == NULL)
+	if (!entry)
 		return;
 
 	for_each_possible_cpu(i) {
-- 
2.12.2

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 2/3] kernel-sched: Adjust four checks for null pointers SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-06 21:50 +0200

csiph-web