Re: [PATCH V15 11/11] arm/arm64: KVM: add guest SEA support

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH V15 11/11] arm/arm64: KVM: add guest SEA support
Date	2017-05-08 22:30 +0200
Message-ID	<tEXs5-cz-3@gated-at.bofh.it> (permalink)
References	<txKpX-3KK-7@gated-at.bofh.it> <txKpY-3KK-41@gated-at.bofh.it> <tEUXg-6Yd-5@gated-at.bofh.it> <tEWZ3-8eF-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, May 08, 2017 at 01:54:44PM -0600, Baicar, Tyler wrote:
> This was discussed in the v12 and v13 patch series. There is existing
> code in kvm_handle_guest_abort for injecting an abort back into the
> guest. We only want to do that if it was an abort that was not handled
> by the firmware first handling. So here we verify that at least one of
> the SEA error sources successfully reported an error record sent from
> the firmware. If there were no errors reported by firmware, then we
> want to continue with the current implementation that will inject the
> virtual abort. (kvm_inject_vabt)

So this needs to be in a comment there. This is generic code in the
sense that it is in drivers/acpi/ and it should say why it is doing that
special thing. I know, SEA is ARM-only, as far as I'm gathering from
reviewing this, but this behavior needs to be documented as it is not
obvious.

Thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH V15 11/11] arm/arm64: KVM: add guest SEA support Borislav Petkov <bp@alien8.de> - 2017-05-08 19:50 +0200
  Re: [PATCH V15 11/11] arm/arm64: KVM: add guest SEA support "Baicar, Tyler" <tbaicar@codeaurora.org> - 2017-05-08 22:00 +0200
    Re: [PATCH V15 11/11] arm/arm64: KVM: add guest SEA support Borislav Petkov <bp@alien8.de> - 2017-05-08 22:30 +0200

csiph-web