Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1637702

Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port into host-only and core structures

From Peter Senna Tschudin <peter.senna@collabora.com>
Newsgroups linux.kernel
Subject Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port into host-only and core structures
Date 2017-05-08 22:40 +0200
Message-ID <tEXBL-g6-7@gated-at.bofh.it> (permalink)
References <tESsq-5wT-29@gated-at.bofh.it> <tETRw-6jm-19@gated-at.bofh.it> <tEV6V-71B-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, May 08, 2017 at 06:55:36PM +0100, Lorenzo Pieralisi wrote:
> On Mon, May 08, 2017 at 06:34:08PM +0200, Lucas Stach wrote:
> > Am Montag, den 08.05.2017, 17:02 +0200 schrieb Peter Senna Tschudin:
> > > Hello Kishon,
> > > 
> > > Our iMX6 hardware (imx6q-b850v3.dts) is not booting with latest
> > > linux-next and I could bisect until:
> > > 
> > > commit 442ec4c04d1235f8c664a74004dae54a7a574d18
> > > Author: Kishon Vijay Abraham I <kishon@ti.com>
> > > Date:   Wed Feb 15 18:48:14 2017 +0530
> > > 
> > >     PCI: dwc: all: Split struct pcie_port into host-only and core structures
> > > 
> > > Which seem to be causing our issues. Our device (imx6q-b850v3.dts) boots
> > > fine with 4.10, and also boots if we disable pcie with:
> > 
> > Are you sure about this bisect? It seems more likely that the secondary
> > bus scanning goes wrong. It seems Lorenzo Pieralisi's cfg space
> > non-posting patches landed in next, so the root cause of this might just
> > be the driver hooking the wrong fault code now.
> > 
> > Async and synchronous aborts are different fault codes on ARM. Can you
> > see of removing the "16 +" in hook_fault_code() in
> > drivers/pci/dwc/pci-imx6.c fixes this issue?
> 
> You can also s/pci_remap_cfgspace/ioremap in pcie-designware-host.c
> to see if my patches are the issue, it is quite a mechanical change.

No change. Exactly same issue, but I noticed that
devm_pci_remap_cfgspace() is called twice for the same device, can this
be a problem?

...
[    0.505069] OF: PCI: host bridge /soc/pcie@1ffc000 ranges:
[    0.510586] OF: PCI:    IO 0x01f80000..0x01f8ffff -> 0x00000000
[    0.516474] OF: PCI:   MEM 0x01000000..0x01efffff -> 0x01000000
[    0.522420] imx6q-pcie 1ffc000.pcie: devm_pci_remap_cfgspace()
[    0.528656] imx6q-pcie 1ffc000.pcie: devm_pci_remap_cfgspace()
...

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port into  host-only and core structures Peter Senna Tschudin <peter.senna@collabora.com> - 2017-05-08 17:10 +0200
  Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Joao Pinto <Joao.Pinto@synopsys.com> - 2017-05-08 17:20 +0200
    Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Kishon Vijay Abraham I <kishon@ti.com> - 2017-05-08 17:30 +0200
      Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Joao Pinto <Joao.Pinto@synopsys.com> - 2017-05-08 17:40 +0200
        Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Kishon Vijay Abraham I <kishon@ti.com> - 2017-05-08 17:50 +0200
  Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Kishon Vijay Abraham I <kishon@ti.com> - 2017-05-08 17:50 +0200
    Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Kishon Vijay Abraham I <kishon@ti.com> - 2017-05-08 18:00 +0200
      Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Peter Senna Tschudin <peter.senna@collabora.com> - 2017-05-08 19:20 +0200
    Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Peter Senna Tschudin <peter.senna@collabora.com> - 2017-05-08 18:20 +0200
  Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Lucas Stach <l.stach@pengutronix.de> - 2017-05-08 18:40 +0200
    Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Peter Senna Tschudin <peter.senna@collabora.com> - 2017-05-08 18:50 +0200
      Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Lucas Stach <l.stach@pengutronix.de> - 2017-05-08 18:50 +0200
        Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Peter Senna Tschudin <peter.senna@collabora.com> - 2017-05-08 19:00 +0200
    Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-05-08 20:00 +0200
      Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Peter Senna Tschudin <peter.senna@collabora.com> - 2017-05-08 22:40 +0200
        Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-05-09 18:30 +0200
  Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-05-08 20:30 +0200
  Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Fabio Estevam <festevam@gmail.com> - 2017-05-09 03:40 +0200
    Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Peter Senna Tschudin <peter.senna@collabora.com> - 2017-05-09 08:40 +0200
      Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Fabio Estevam <festevam@gmail.com> - 2017-05-09 12:30 +0200
        Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Peter Senna Tschudin <peter.senna@collabora.com> - 2017-05-10 15:20 +0200
          Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Fabio Estevam <festevam@gmail.com> - 2017-05-10 15:30 +0200
            Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Lucas Stach <l.stach@pengutronix.de> - 2017-05-10 15:40 +0200
              Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port  into host-only and core structures Peter Senna Tschudin <peter.senna@collabora.com> - 2017-05-10 16:20 +0200

csiph-web