Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1637544

Re: [PATCH] net: ipv4: add code comment for clarification

Show all headers | View raw

Hi David,

Quoting David Miller <davem@davemloft.net>:

> From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
> Date: Thu, 4 May 2017 14:44:16 -0500
>
>> @@ -389,6 +389,12 @@ static int sk_diag_fill(struct sock *sk,  
>> struct sk_buff *skb,
>>  				  nlmsg_flags, unlh, net_admin);
>>  }
>>
>> +/*
>> + * Ignore the position of the arguments req->id.idiag_dport and
>> + * req->id.idiag_sport in both calls to inet_lookup() and inet6_lookup()
>> + * functions, once this is a locked in behavior exposed to user space.
>> + * Changing this will break things for people.
>> + */
>
> This is implicit for every interface exposed to userspace.
>
> Therefore, saying it here and there in various comments provides
> questionable value.
>
> And in fact I think these arguments are probably in the correct order.
>
> I'm definitely not applying a patch like this, sorry.

I get it, thanks for clarifying.
--
Gustavo A. R. Silva

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[net-ipv4] question about arguments position "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-04 18:10 +0200
  Re: [net-ipv4] question about arguments position David Miller <davem@davemloft.net> - 2017-05-04 18:50 +0200
    Re: [net-ipv4] question about arguments position Joe Perches <joe@perches.com> - 2017-05-04 19:50 +0200
      Re: [net-ipv4] question about arguments position Joe Perches <joe@perches.com> - 2017-05-04 21:10 +0200
        Re: [net-ipv4] question about arguments position Joe Perches <joe@perches.com> - 2017-05-04 21:20 +0200
          Re: [net-ipv4] question about arguments position "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-04 21:30 +0200
            [PATCH] net: ipv4: add code comment for clarification "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-04 22:10 +0200
              Re: [PATCH] net: ipv4: add code comment for clarification David Miller <davem@davemloft.net> - 2017-05-08 17:40 +0200
                Re: [PATCH] net: ipv4: add code comment for clarification "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-08 18:10 +0200
        Re: [net-ipv4] question about arguments position "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-04 21:20 +0200
      Re: [net-ipv4] question about arguments position "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-04 21:50 +0200
    Re: [net-ipv4] question about arguments position "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-04 20:00 +0200

csiph-web