[PATCH] gpio: mcp23s08: Use seq_putc() in mcp23s08_dbg_show()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	[PATCH] gpio: mcp23s08: Use seq_putc() in mcp23s08_dbg_show()
Date	2017-05-08 13:00 +0200
Message-ID	<tEOyt-2Rv-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 8 May 2017 12:44:36 +0200

A single character (line break) should be put into a sequence.
Thus use the corresponding function "seq_putc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/gpio/gpio-mcp23s08.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-mcp23s08.c b/drivers/gpio/gpio-mcp23s08.c
index 2a57d024481d..51dff7e95a9e 100644
--- a/drivers/gpio/gpio-mcp23s08.c
+++ b/drivers/gpio/gpio-mcp23s08.c
@@ -519,7 +519,7 @@ static void mcp23s08_dbg_show(struct seq_file *s, struct gpio_chip *chip)
 			(mcp->cache[MCP_GPIO] & mask) ? "hi" : "lo",
 			(mcp->cache[MCP_GPPU] & mask) ? "up" : "  ");
 		/* NOTE:  ignoring the irq-related registers */
-		seq_puts(s, "\n");
+		seq_putc(s, '\n');
 	}
 done:
 	mutex_unlock(&mcp->lock);
-- 
2.12.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] gpio: mcp23s08: Use seq_putc() in mcp23s08_dbg_show() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-08 13:00 +0200
  Re: [PATCH] gpio: mcp23s08: Use seq_putc() in mcp23s08_dbg_show() Linus Walleij <linus.walleij@linaro.org> - 2017-05-11 16:40 +0200

csiph-web