Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1637321

Re: [PATCH] regulator: max8997/8966: fix charger cv voltage set bug

From Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Newsgroups linux.kernel
Subject Re: [PATCH] regulator: max8997/8966: fix charger cv voltage set bug
Date 2017-05-08 11:20 +0200
Message-ID <tEMZI-1ZS-11@gated-at.bofh.it> (permalink)
References <tEJIt-83h-3@gated-at.bofh.it> <tEJIt-83h-5@gated-at.bofh.it> <tEJIt-83h-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Monday, May 08, 2017 05:45:44 AM MyungJoo Ham wrote:
> 
> When min charger-CV is <= 4.0V and max charger-CV is >= 4.0V,
> we can use 4.00V as CV (register value = 0x1).`
> 
> The original code had a typo that wrote ">=" (max_uV >= 4000000),
> which should've been "<", which is not necessary anyway
> as mentioned by Dan Carpenter.
> 
> Reported-By: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>

Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] regulator: max8997/8966: fix charger cv voltage set bug MyungJoo Ham <myungjoo.ham@samsung.com> - 2017-05-08 07:50 +0200
  Re: [PATCH] regulator: max8997/8966: fix charger cv voltage set bug Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2017-05-08 11:20 +0200
  Re: [PATCH] regulator: max8997/8966: fix charger cv voltage set bug Chanwoo Choi <cw00.choi@samsung.com> - 2017-05-10 01:40 +0200

csiph-web