Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1637223

[V4] staging : rtl8188eu : remove void function return

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Surender Polsani <surenderpolsani@gmail.com>
Newsgroups linux.kernel
Subject [V4] staging : rtl8188eu : remove void function return
Date Mon, 08 May 2017 08:00:02 +0200
Message-ID <tEJSa-896-9@gated-at.bofh.it> (permalink)
X-Original-To gregkh@linuxfoundation.org
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=hw3Ql2vrkOF3cmPuzwAip9XUZrSAJ21wgJTzbA3qbhk=; b=oQB5QdQUkW6pDmDHmh863aCe9mfS0S8CLEmjhUh9zUK1HFWAqzu1S1HJ1XYIDQ+4MG xvklrGj+FAD4u3zGjdn/l9qLO0L/QawppPw3wguGptME4H9YFqNpSmqi/mJIJe9CMC24 1uinB8fUgfyTlrf3YEfQ4kNta+BJ69pl91WR3yi7wGWQgCQCk8z14DcN4TQ2LYjLMshA KEp4g628QsNpN1gfIZm7o+0lgrhfpHsb8ji0CFbrkjmA7Akh+IjlooHo5iPzS1/Gs3cb JuJmLzDXmP5k6aTCAQuQjzheY/meqplPpb8HPHJ2LYtHjuBsWlAgwmYC9DIfa/rRw5wN zrpQ==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=hw3Ql2vrkOF3cmPuzwAip9XUZrSAJ21wgJTzbA3qbhk=; b=os/vwB+u9QxOIy4HJH+GwMInP+0cfZ30I3cjOb1OOKK5Erm9D7J/g2MLrHD2oH05E+ Xovq6sUJwt+ZV4yenwlk3ee3kscFQoPVshFfx8964Ki0UM0h40lXN2ACeBsDEATHj646 A+99ods+tbSl5km/K7vwQmFMgCchNgNExq6uZIENt2FhuG1e+4KDBWTIkZrZbUleXjlA cwpyBYZ34wx7WxCSFwylufsE2jweFrvwQtcMHBRiB5dlPGozbxGNga+Zv/ICAr4hUeIY 93ku9atoFmlRyWHVR4AH2g7akjvwXmn1cnl0iuzWEpmCN1lpEYBhiCs6nrol6tkpSh2X gISg==
X-Gm-Message-State AODbwcBM0NyS+a/pEmhE+4GB8aMUFsv3hYNlOG1bt0goqUz7tGmmGS3C 5C/2mUWxP6sDoK6By3M=
X-Received by 10.84.133.132 with SMTP id f4mr7302344plf.94.1494222764849; Sun, 07 May 2017 22:52:44 -0700 (PDT)
X-Mailer git-send-email 1.9.1
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 39
Organization linux.* mail to news gateway
X-Original-Cc devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Surender Polsani <surenderpolsani@gmail.com>
X-Original-Date Mon, 8 May 2017 11:22:35 +0530
X-Original-Message-ID <1494222755-25850-1-git-send-email-surenderpolsani@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1637223

Show key headers only | View raw


kernel coding style doesn't allow the return statement
in void function.

Signed-off-by: Surender Polsani <surenderpolsani@gmail.com>
---
Changes for v2:
corrected subject line as suggested
Changes for v3:
modified from line as suggested by Greg KH
placed a semicolon in label for fixing build error
Changes for v4:
changes made as suggested by Dan Carpenter
---
 drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
index d04b7fb..bf9f10f 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
@@ -146,7 +146,6 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter)
 
 	if (!hw_init_completed)
 		goto skip_dm;
-
 	/* ODM */
 	pmlmepriv = &Adapter->mlmepriv;
 
@@ -165,7 +164,7 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter)
 skip_dm:
 	/*  Check GPIO to determine current RF on/off and Pbc status. */
 	/*  Check Hardware Radio ON/OFF or not */
-	return;
+	;
 }
 
 void rtw_hal_dm_init(struct adapter *Adapter)
-- 
1.9.1

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[V4] staging : rtl8188eu : remove void function return Surender Polsani <surenderpolsani@gmail.com> - 2017-05-08 08:00 +0200
  Re: [V4] staging : rtl8188eu : remove void function return Greg KH <gregkh@linuxfoundation.org> - 2017-05-08 08:10 +0200
    Re: [V4] staging : rtl8188eu : remove void function return Joe Perches <joe@perches.com> - 2017-05-08 08:30 +0200

csiph-web