Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1637207

Re: [PATCH] staging: iio: meter: This patch fixes warnings found in ade7753.c

From Greg KH <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH] staging: iio: meter: This patch fixes warnings found in ade7753.c
Date 2017-05-08 06:40 +0200
Message-ID <tEICJ-7qh-1@gated-at.bofh.it> (permalink)
References <tEIjn-7gc-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, May 08, 2017 at 12:16:17AM -0400, Harinath Nampally wrote:
> All below warnings are found and fixed by checkpatch.pl:
> CHECK: struct mutex definition without comment
> CHECK: Alignment should match open parenthesis
> WARNING: Symbolic permissions 'S_IWUSR | S_IRUGO' are not preferred.

You should only don "one thing" per patch, and no, "fix coding style
issues" is not "one thing" :)

Please break this up into multiple patches and send it as a patch
series.

thanks,

greg k-h

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] staging: iio: meter: This patch fixes warnings found in ade7753.c Harinath Nampally <harinath922@gmail.com> - 2017-05-08 06:20 +0200
  Re: [PATCH] staging: iio: meter: This patch fixes warnings found in  ade7753.c Greg KH <gregkh@linuxfoundation.org> - 2017-05-08 06:40 +0200
    Re: [PATCH] staging: iio: meter: This patch fixes warnings found in  ade7753.c Greg KH <gregkh@linuxfoundation.org> - 2017-05-08 07:50 +0200

csiph-web