Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1637138

Re: [PATCH 3/3] Staging: rtl8712: ieee80211: fixed camelcase coding style issue

Show all headers | View raw

On Mon, 2017-05-08 at 00:45 +0530, Jaya Durga wrote:
> Fixed coding style issue

Please list the various renames you are doing.

BeaconPeriod	-> beacon_period
DSConfig	-> ds_config
ATIMWindow	-> atim_window

etc...

And it's generally better to do these while avoiding
changing line breaks.


There are maintainers that also would want these
renames done in individual separate patches.

> diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c
[]
> @@ -174,7 +174,8 @@ int r8712_generate_ie(struct registry_priv *pregistrypriv)
>  	sz += 8;
>  	ie += sz;
>  	/*beacon interval : 2bytes*/
> -	*(__le16 *)ie = cpu_to_le16((u16)pdev_network->Configuration.BeaconPeriod);
> +	*(__le16 *)ie = cpu_to_le16(
> +				(u16)pdev_network->configuration.beacon_period);

It's also frequently better to use a temporary pointer
and convert these relatively long indirections to
something simpler like:

	<whatever_type> *cfg = &pdev_network->configuration;

	*(__le16 *)ie = cpu_to_le16(cfg->beacon_period);

etc...

in separate patches.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] Staging: rtl8712: ieee80211: fixed camelcase coding style issue Jaya Durga <jayad@cdac.in> - 2017-05-08 00:10 +0200
  Re: [PATCH 3/3] Staging: rtl8712: ieee80211: fixed camelcase coding  style issue Joe Perches <joe@perches.com> - 2017-05-08 01:10 +0200

csiph-web