Re: [PATCH] perf, tools: Support srccode output

From	Andi Kleen <ak@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] perf, tools: Support srccode output
Date	2017-05-08 00:10 +0200
Message-ID	<tECxk-3oj-17@gated-at.bofh.it> (permalink)
References	<tDUwh-8nd-3@gated-at.bofh.it> <tECnF-34t-45@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> so get_srcline formats srcline and you parse it out back in here,
> I think it'd be better to factor __get_srcline and get the file
> and line directly

It's not true for the addr2line fallback which gets the already formatted 
string. So at some point it would need to be parsed.

But ok I can move it into the low level function. It just makes the patch
more complicated.

-Andi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] perf, tools: Support srccode output Andi Kleen <andi@firstfloor.org> - 2017-05-06 01:10 +0200
  Re: [PATCH] perf, tools: Support srccode output Jiri Olsa <jolsa@redhat.com> - 2017-05-08 00:00 +0200
  Re: [PATCH] perf, tools: Support srccode output Jiri Olsa <jolsa@redhat.com> - 2017-05-08 00:00 +0200
    Re: [PATCH] perf, tools: Support srccode output Andi Kleen <ak@linux.intel.com> - 2017-05-08 00:10 +0200

csiph-web