Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1637043

Re: [PATCH] Fix spaces ERROR in atomisp_gmin_platform.c

From Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH] Fix spaces ERROR in atomisp_gmin_platform.c
Date 2017-05-08 00:00 +0200
Message-ID <tECnE-34t-25@gated-at.bofh.it> (permalink)
References <tDXua-1X9-7@gated-at.bofh.it> <tE7tw-8by-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, May 06, 2017 at 03:56:23PM +0300, Gideon Sheril wrote:
>  int atomisp_register_i2c_module(struct v4l2_subdev *subdev,
> -                                struct camera_sensor_platform_data *plat_data,
> -                                enum intel_v4l2_subdev_type type)
> +	struct camera_sensor_platform_data *plat_data,
> +	enum intel_v4l2_subdev_type type)

It was aligned properly before, it just used spaces instead of tabs.

> +		dev_info(&client->dev,
> +			"camera pdata: port: %d lanes: %d order: %8.8x\n",
> +			port, lanes, bayer_order);

This introduces a checkpatch.pl warning.  Do it like this:

[tab][tab][tab][space]"camera pdata: port: %d lanes: %d order: %8.8x\n",

regards,
dan carpenter

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] staging/media/atomisp/platform/intel-mid change spaces to tabs and comma/assignment space padding Gideon Sheril <elmocia@gmail.com> - 2017-05-06 03:10 +0200
  Re: [PATCH] staging/media/atomisp/platform/intel-mid change spaces  to tabs and comma/assignment space padding Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-06 04:20 +0200
    [PATCH] Fix spaces ERROR in atomisp_gmin_platform.c Gideon Sheril <elmocia@gmail.com> - 2017-05-06 15:00 +0200
      Re: [PATCH] Fix spaces ERROR in atomisp_gmin_platform.c Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-08 00:00 +0200
        [PATCH v3] staging: media: atomisp: Fix indentation to tabs Gideon Sheril <elmocia@gmail.com> - 2017-05-08 19:10 +0200

csiph-web