Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1636928

[PATCH] lightnvm: fix error return code of memdup_user

From Geliang Tang <geliangtang@gmail.com>
Newsgroups linux.kernel
Subject [PATCH] lightnvm: fix error return code of memdup_user
Date 2017-05-06 17:40 +0200
Message-ID <tE9Ym-1qG-15@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


The error return code of memdup_user() should be -ENOMEM or -EFAULT.
So this patch changed it to PTR_ERR(info).

Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
 drivers/lightnvm/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
index 54a06c3..e8b5edd 100644
--- a/drivers/lightnvm/core.c
+++ b/drivers/lightnvm/core.c
@@ -1164,7 +1164,7 @@ static long nvm_ioctl_info(struct file *file, void __user *arg)
 
 	info = memdup_user(arg, sizeof(struct nvm_ioctl_info));
 	if (IS_ERR(info))
-		return -EFAULT;
+		return PTR_ERR(info);
 
 	info->version[0] = NVM_VERSION_MAJOR;
 	info->version[1] = NVM_VERSION_MINOR;
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH] lightnvm: fix error return code of memdup_user Geliang Tang <geliangtang@gmail.com> - 2017-05-06 17:40 +0200
  Re: [PATCH] lightnvm: fix error return code of memdup_user Matias Bjørling <m@bjorling.me> - 2017-05-08 09:00 +0200

csiph-web