Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1636042
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 7/9] drm/i915: Combine substrings for a message in gen6_drpc_info() |
| Date | 2017-05-04 22:50 +0200 |
| Message-ID | <tDvRf-5o-1@gated-at.bofh.it> (permalink) |
| References | <tDsgF-6aT-3@gated-at.bofh.it> <tDsgF-6aT-19@gated-at.bofh.it> <tDvoe-8mr-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
>> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
>> @@ -1529,8 +1529,8 @@ static int gen6_drpc_info(struct seq_file *m)
>>
>> forcewake_count = READ_ONCE(dev_priv->uncore.fw_domain[FW_DOMAIN_ID_RENDER].wake_count);
>> if (forcewake_count) {
>> - seq_puts(m, "RC information inaccurate because somebody "
>> - "holds a forcewake reference \n");
>> + seq_puts(m,
>> + "RC information inaccurate because somebody holds a forcewake reference.\n");
>
> And now you break the 80col rule. Blind adherence to checkpatch is impossible.
Have you got any other coding style preferences around the grepping
of longer message strings from such source code?
Regards,
Markus
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 7/9] drm/i915: Combine substrings for a message in gen6_drpc_info() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-04 19:00 +0200
Re: [PATCH 7/9] drm/i915: Combine substrings for a message in gen6_drpc_info() Chris Wilson <chris@chris-wilson.co.uk> - 2017-05-04 22:20 +0200
Re: [PATCH 7/9] drm/i915: Combine substrings for a message in gen6_drpc_info() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-04 22:50 +0200
Re: [PATCH 7/9] drm/i915: Combine substrings for a message in gen6_drpc_info() Chris Wilson <chris@chris-wilson.co.uk> - 2017-05-04 23:00 +0200
Re: [PATCH 7/9] drm/i915: Combine substrings for a message in gen6_drpc_info() Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-05 07:00 +0200
csiph-web