Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1635983

Re: [PATCH] x86/build: don't add -maccumulate-outgoing-args w/o compiler support

From Josh Poimboeuf <jpoimboe@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH] x86/build: don't add -maccumulate-outgoing-args w/o compiler support
Date 2017-05-04 21:20 +0200
Message-ID <tDus9-7Mu-15@gated-at.bofh.it> (permalink)
References <tDiqZ-8aF-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, May 03, 2017 at 11:23:41PM -0700, Nick Desaulniers wrote:
> Otherwise other compilers, like Clang, are prevented from compiling the
> kernel. This flag was introduced in
> 3f135e57a4f76d24ae8d8a490314331f0ced40c5.
> 
> Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
> ---
>  arch/x86/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/Makefile b/arch/x86/Makefile
> index 4430dd4..5a0ac84 100644
> --- a/arch/x86/Makefile
> +++ b/arch/x86/Makefile
> @@ -179,7 +179,7 @@ ifdef CONFIG_JUMP_LABEL
>  endif
>  
>  ifeq ($(ACCUMULATE_OUTGOING_ARGS), 1)
> -	KBUILD_CFLAGS += -maccumulate-outgoing-args
> +	KBUILD_CFLAGS += $(call cc-option,-maccumulate-outgoing-args,)
>  endif

I think this might silently cover up errors for older versions of gcc.
For example, what happens if '-maccumulate-outgoing-args' is needed, but
the version of gcc doesn't support it.  In that case I'd rather see gcc
report an error that the flag isn't supported, instead of it getting
silently disabled.

So how about this instead?

	KBUILD_CFLAGS += $(if $(filter gcc,$(cc-name)),-maccumulate-outgoing-args)

-- 
Josh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86/build: don't add -maccumulate-outgoing-args w/o compiler support Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-04 08:30 +0200
  Re: [PATCH] x86/build: don't add -maccumulate-outgoing-args w/o  compiler support Josh Poimboeuf <jpoimboe@redhat.com> - 2017-05-04 21:20 +0200
    [Patch v2] x86/build: require only gcc use -maccumulate-outgoing-args Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-05 05:20 +0200
      Re: [Patch v2] x86/build: require only gcc use  -maccumulate-outgoing-args Ingo Molnar <mingo@kernel.org> - 2017-05-05 08:30 +0200
        Re: [Patch v2] x86/build: require only gcc use -maccumulate-outgoing-args hpa@zytor.com - 2017-05-05 08:50 +0200
          Re: [Patch v2] x86/build: require only gcc use  -maccumulate-outgoing-args Josh Poimboeuf <jpoimboe@redhat.com> - 2017-05-05 15:10 +0200
            [Patch v3] x86/build: don't add -maccumulate-outgoing-args w/o compiler support Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-06 05:10 +0200
              Re: [Patch v3] x86/build: don't add -maccumulate-outgoing-args w/o  compiler support Josh Poimboeuf <jpoimboe@redhat.com> - 2017-05-08 05:30 +0200
                [Patch v4] x86/build: don't add -maccumulate-outgoing-args w/o compiler support Nick Desaulniers <nick.desaulniers@gmail.com> - 2017-05-09 05:40 +0200
                Re: [Patch v4] x86/build: don't add -maccumulate-outgoing-args w/o  compiler support Josh Poimboeuf <jpoimboe@redhat.com> - 2017-05-09 05:50 +0200
                [tip:x86/urgent] x86/build: Don't add -maccumulate-outgoing-args  w/o compiler support tip-bot for Nick Desaulniers <tipbot@zytor.com> - 2017-05-09 08:50 +0200

csiph-web