Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1635991
| From | Tyrel Datwyler <tyreld@linux.vnet.ibm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] scsi: pmcraid: remove redundant check to see if request_size is less than zero |
| Date | 2017-05-04 21:50 +0200 |
| Message-ID | <tDuVb-7WB-3@gated-at.bofh.it> (permalink) |
| References | <tD5k6-7NI-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 05/03/2017 09:29 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The 2nd check to see if request_size is less than zero is redundant
> because the first check takes error exit path on this condition. So,
> since it is redundant, remove it.
>
> Detected by CoverityScan, CID#146149 ("Logically Dead Code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] scsi: pmcraid: remove redundant check to see if request_size is less than zero Colin King <colin.king@canonical.com> - 2017-05-03 18:30 +0200 Re: [PATCH] scsi: pmcraid: remove redundant check to see if request_size is less than zero Tyrel Datwyler <tyreld@linux.vnet.ibm.com> - 2017-05-04 21:50 +0200 Re: [PATCH] scsi: pmcraid: remove redundant check to see if request_size is less than zero "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-05-09 04:20 +0200
csiph-web