Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1635958

Re: [PATCH 2/3] nVMX: Implement emulated Page Modification Logging

From Bandan Das <bsd@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/3] nVMX: Implement emulated Page Modification Logging
Date 2017-05-04 20:20 +0200
Message-ID <tDtw6-7aO-7@gated-at.bofh.it> (permalink)
References <tDaMN-2Zz-11@gated-at.bofh.it> <tDaMN-2Zz-13@gated-at.bofh.it> <tDlfb-1wD-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Paolo Bonzini <pbonzini@redhat.com> writes:

> On 04/05/2017 00:14, Bandan Das wrote:
>> +	if (vmx->nested.pml_full) {
>> +		exit_reason = EXIT_REASON_PML_FULL;
>> +		vmx->nested.pml_full = false;
>> +	} else if (fault->error_code & PFERR_RSVD_MASK)
>>  		exit_reason = EXIT_REASON_EPT_MISCONFIG;
>>  	else
>>  		exit_reason = EXIT_REASON_EPT_VIOLATION;
>> +	/*
>> +	 * The definition of bit 12 for EPT violations and PML
>> +	 * full event is the same, so pass it through since
>> +	 * the rest of the bits are undefined.
>> +	 */
>
> Please zero all other bits instead.  It's as easy as adding an "u64
> exit_qualification" local variable.

Will do, thanks for the review.

Bandan

> Paolo
>
>>  	nested_vmx_vmexit(vcpu, exit_reason, 0, vcpu->arch.exit_qualification);

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] nVMX: Emulated Page Modification Logging for Nested Virtualization Bandan Das <bsd@redhat.com> - 2017-05-04 00:20 +0200
  [PATCH 2/3] nVMX: Implement emulated Page Modification Logging Bandan Das <bsd@redhat.com> - 2017-05-04 00:20 +0200
    Re: [PATCH 2/3] nVMX: Implement emulated Page Modification Logging Paolo Bonzini <pbonzini@redhat.com> - 2017-05-04 11:30 +0200
      Re: [PATCH 2/3] nVMX: Implement emulated Page Modification Logging Bandan Das <bsd@redhat.com> - 2017-05-04 20:20 +0200
  [PATCH 3/3] nVMX: Advertise PML to L1 hypervisor Bandan Das <bsd@redhat.com> - 2017-05-04 00:20 +0200
    Re: [PATCH 3/3] nVMX: Advertise PML to L1 hypervisor Paolo Bonzini <pbonzini@redhat.com> - 2017-05-04 09:10 +0200
      Re: [PATCH 3/3] nVMX: Advertise PML to L1 hypervisor Bandan Das <bsd@redhat.com> - 2017-05-04 20:30 +0200
        Re: [PATCH 3/3] nVMX: Advertise PML to L1 hypervisor Paolo Bonzini <pbonzini@redhat.com> - 2017-05-05 09:30 +0200

csiph-web