Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1635887

Re: [PATCH 1/4] KVM: svm: prevent MWAIT in guest with erratum 400

Show all headers | View raw

On Thu, May 04, 2017 at 04:02:44PM +0200, Radim Krčmář wrote:
> X86_BUG_AMD_APIC_C1E doesn't cover C3, which is why I used
> X86_BUG_AMD_E400.

Practically, the CPUs which even support C3 with E400 are single-core
devices and C3 support was removed with revision C3 (yap, the same as
the ACPI state) so I think we can safely ignore C3 here.

I mean, otherwise, we would be seeing E400 in action as our workaround
would not be sufficient. And even then, I don't think we ever go into C3
on those machines as we do HLT which enters C1.

> The host uses APIC timer when entering a guest and I assumed that MWAIT
> can change C states, but it seems that affected AMD models do not even
> support MWAIT hints and the package is in C0 the whole time.

Right, we never do MWAIT when idle on AMD but HLT.

I notice now that MWAIT text has received recent additions talking
about C-state hints but we'd need to evaluate that first and how power
consumption behaves and it probably would work the same way as it does
on Intel.

Thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] KVM: svm: prevent MWAIT in guest with erratum 400 Radim Krčmář <rkrcmar@redhat.com> - 2017-05-03 21:40 +0200
  Re: [PATCH 1/4] KVM: svm: prevent MWAIT in guest with erratum 400 Borislav Petkov <bp@alien8.de> - 2017-05-03 22:20 +0200
    Re: [PATCH 1/4] KVM: svm: prevent MWAIT in guest with erratum 400 Radim Krčmář <rkrcmar@redhat.com> - 2017-05-04 16:10 +0200
      Re: [PATCH 1/4] KVM: svm: prevent MWAIT in guest with erratum 400 Borislav Petkov <bp@alien8.de> - 2017-05-04 18:50 +0200

csiph-web