Re: [PATCH 2/5] dmaengine: Add STM32 DMAMUX driver

From	Pierre Yves MORDRET <pierre-yves.mordret@st.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/5] dmaengine: Add STM32 DMAMUX driver
Date	2017-05-04 17:30 +0200
Message-ID	<tDqRA-5hr-9@gated-at.bofh.it> (permalink)
References	<tkyZj-1HR-3@gated-at.bofh.it> <tkyZk-1HR-17@gated-at.bofh.it> <tt9p0-4Yc-15@gated-at.bofh.it> <tArKc-tv-67@gated-at.bofh.it> <tCcGZ-5pN-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 05/01/2017 08:03 AM, Vinod Koul wrote:
> On Wed, Apr 26, 2017 at 09:17:37AM +0000, Pierre Yves MORDRET wrote:
>>>> +
>>>> +	ret = of_property_read_u32(node, "dma-channels",
>>>> +				   &dmamux->dmamux_channels);
>>>
>>> can we have property_xxx calls alone, that way driver is not strictly
>>> dependent on of
>>
>> Can you please explain what you are asking for ? Not sure to understand
>> correctly.
>
> Use device_property_read_u32() which is a generic property API.

OK Will be done in V2

>
>
>>>> +static int __init stm32_dmamux_init(void)
>>>> +{
>>>> +	return platform_driver_register(&stm32_dmamux_driver);
>>>> +}
>>>> +arch_initcall(stm32_dmamux_init);
>>>
>>> why not module init, wouldnt defer probe solve the dependencies
>>>
>>
>> The reason behind many devices (device_initcall level) rely on DMAs. If
>> init is deferred DMAMUX driver will be probed twice if dependents rely
>> on it. This sounds not a good call. This explains arch_initcall level.
>
> Why not deferred probe was introduced to help with dependencies...
>

Most DMAs devices are already in subsys_initcall to avoid multiple 
useless probe when clients are deferred. This DMAMUx is itself on top of 
DMAs.
DMAMUX ---> DMA#1 ---> Device Client #1
        |          |--> Device Client #2
        |               [...]
        |          |--> Device Client #N
        |    [...]
        |--> DMA#N ---> Device Client #1
                   |--> Device Client #2
                        [...]
                   |--> Device Client #N
arch_initcall might a good call in this case for DMAMUX.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/5] dmaengine: Add STM32 DMAMUX driver Pierre Yves MORDRET <pierre-yves.mordret@st.com> - 2017-04-26 11:50 +0200
  Re: [PATCH 2/5] dmaengine: Add STM32 DMAMUX driver Vinod Koul <vinod.koul@intel.com> - 2017-05-01 08:10 +0200
    Re: [PATCH 2/5] dmaengine: Add STM32 DMAMUX driver Pierre Yves MORDRET <pierre-yves.mordret@st.com> - 2017-05-04 17:30 +0200

csiph-web