Re: net/dccp: dccp_create_openreq_child freed held lock

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: net/dccp: dccp_create_openreq_child freed held lock
Date	2017-05-04 16:20 +0200
Message-ID	<tDpsu-4bq-13@gated-at.bofh.it> (permalink)
References	<tgewa-4ZE-39@gated-at.bofh.it> <tgeFQ-55d-15@gated-at.bofh.it> <tDp97-43E-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Andrey Konovalov <andreyknvl@google.com>
Date: Thu, 4 May 2017 15:36:37 +0200

> On Wed, Mar 1, 2017 at 4:40 PM, Arnaldo Carvalho de Melo
> <acme@kernel.org> wrote:
>> Em Wed, Mar 01, 2017 at 12:35:10PM -0300, Arnaldo Carvalho de Melo escreveu:
>>> Em Wed, Mar 01, 2017 at 10:38:54AM +0100, Dmitry Vyukov escreveu:
>>> > Hello,
>>> >
>>> > I've got the following report while running syzkaller fuzzer on
>>> > 86292b33d4b79ee03e2f43ea0381ef85f077c760:
>>> >
>>> >
>>> > It seems that dccp_create_openreq_child needs to unlock the sock if
>>> > dccp_feat_activate_values fails.
>>>
>>> Yeah, can you please use the patch below, that mimics the error paths in
>>> sk_clone_new(), from where I think even the comment about it being a raw
>>
>> Argh, s/sk_clone_new()/sk_clone_lock()/g
> 
> Hi Arnaldo,
> 
> Could you send the patch?
> 
> We haven't seen these reports since we applied it.

It isn't necessary in the current tree.

Arnaldo created a helper sk_free_unlock_clone() which handles this situation
properly, and calls it from dccp_create_openreq_child().

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: net/dccp: dccp_create_openreq_child freed held lock Andrey Konovalov <andreyknvl@google.com> - 2017-05-04 15:40 +0200
  Re: net/dccp: dccp_create_openreq_child freed held lock Andrey Konovalov <andreyknvl@google.com> - 2017-05-04 16:00 +0200
  Re: net/dccp: dccp_create_openreq_child freed held lock David Miller <davem@davemloft.net> - 2017-05-04 16:20 +0200

csiph-web