Re: [PATCH 1/2] rtc: ds1374: wdt: Fix issue with timeout scaling from secs to wdt ticks

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] rtc: ds1374: wdt: Fix issue with timeout scaling from secs to wdt ticks
Date	2017-05-04 14:50 +0200
Message-ID	<tDomK-3tZ-19@gated-at.bofh.it> (permalink)
References	<tzUlb-4gQ-7@gated-at.bofh.it> <tzUlc-4gQ-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 24/04/2017 at 15:05:11 -0700, Moritz Fischer wrote:
> Fix commit 920f91e50c5b ("drivers/rtc/rtc-ds1374.c: add watchdog support")
> 
> The issue is that the internal counter that triggers the watchdog reset
> is actually running at 4096 Hz instead of 1Hz, therefore the value
> given by userland (in sec) needs to be multiplied by 4096 to get the
> correct behavior.
> 
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> ---
>  drivers/rtc/rtc-ds1374.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] rtc: ds1374: wdt: Fix issue with timeout scaling from secs to wdt ticks Moritz Fischer <mdf@kernel.org> - 2017-04-25 00:10 +0200
  Re: [PATCH 1/2] rtc: ds1374: wdt: Fix issue with timeout scaling  from secs to wdt ticks Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-05-04 14:50 +0200

csiph-web