Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1635674
| From | Bastien Nocera <hadess@hadess.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 4/7] staging: rtl8723bs: Move braces to same line as conditional |
| Date | 2017-05-04 14:00 +0200 |
| Message-ID | <tDnAn-2VI-37@gated-at.bofh.it> (permalink) |
| References | <tCuky-7Ii-3@gated-at.bofh.it> <tCuky-7Ii-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, 2017-05-01 at 18:52 -0600, Justin Vreeland wrote:
> Ensure checkpatch compliance
>
> > Signed-off-by: Justin Vreeland <justin@jvreeland.com>
> ---
> v2:
> - Added commit message
> - Fixed overly long lines
>
> drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 18 ++++++++----------
> drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 12 ++++++------
> drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 9 ++++-----
> 3 files changed, 18 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> index 28d1a229c3a6..21ec890fd60c 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> @@ -385,8 +385,7 @@ s32 PHY_MACConfig8723B(struct adapter *Adapter)
> > /* Config MAC */
> > /* */
> > rtStatus = phy_ConfigMACWithParaFile(Adapter, pszMACRegFile);
> > - if (rtStatus == _FAIL)
> > - {
> > + if (rtStatus == _FAIL) {
> > ODM_ConfigMACWithHeaderFile(&pHalData->odmpriv);
> > rtStatus = _SUCCESS;
> > }
> @@ -459,8 +458,7 @@ static int phy_BB8723b_Config_ParaFile(struct adapter *Adapter)
> > Adapter->registrypriv.RegEnableTxPowerLimit == 1 ||
> > (Adapter->registrypriv.RegEnableTxPowerLimit == 2 && pHalData->EEPROMRegulatory == 1)
> > ) {
> > - if (PHY_ConfigRFWithPowerLimitTableParaFile(Adapter, pszRFTxPwrLmtFile) == _FAIL)
> > - {
> > + if (PHY_ConfigRFWithPowerLimitTableParaFile(Adapter, pszRFTxPwrLmtFile) == _FAIL) {
> > if (HAL_STATUS_SUCCESS != ODM_ConfigRFWithHeaderFile(&pHalData->odmpriv, CONFIG_RF_TXPWR_LMT, (ODM_RF_RADIO_PATH_E)0))
> > rtStatus = _FAIL;
> > }
> @@ -474,8 +472,8 @@ static int phy_BB8723b_Config_ParaFile(struct adapter *Adapter)
> > /* */
> > /* 1. Read PHY_REG.TXT BB INIT!! */
> > /* */
> > - if (phy_ConfigBBWithParaFile(Adapter, pszBBRegFile, CONFIG_BB_PHY_REG) == _FAIL)
> > - {
> > + if (phy_ConfigBBWithParaFile(Adapter, pszBBRegFile, CONFIG_BB_PHY_REG) ==
> + _FAIL) {
This and...
> if (HAL_STATUS_SUCCESS != ODM_ConfigBBWithHeaderFile(&pHalData->odmpriv, CONFIG_BB_PHY_REG))
> > rtStatus = _FAIL;
> > }
> @@ -491,8 +489,8 @@ static int phy_BB8723b_Config_ParaFile(struct adapter *Adapter)
> > Adapter->registrypriv.RegEnableTxPowerByRate == 1 ||
> > (Adapter->registrypriv.RegEnableTxPowerByRate == 2 && pHalData->EEPROMRegulatory != 2)
> > ) {
> > - if (phy_ConfigBBWithPgParaFile(Adapter, pszBBRegPgFile) == _FAIL)
> > - {
> > + if (phy_ConfigBBWithPgParaFile(Adapter, pszBBRegPgFile) ==
> > + _FAIL) {
> > if (HAL_STATUS_SUCCESS != ODM_ConfigBBWithHeaderFile(&pHalData->odmpriv, CONFIG_BB_PHY_REG_PG))
> > rtStatus = _FAIL;
> > }
> @@ -514,8 +512,8 @@ static int phy_BB8723b_Config_ParaFile(struct adapter *Adapter)
> > /* */
> > /* 2. Read BB AGC table Initialization */
> > /* */
> > - if (phy_ConfigBBWithParaFile(Adapter, pszAGCTableFile, CONFIG_BB_AGC_TAB) == _FAIL)
> > - {
> > + if (phy_ConfigBBWithParaFile(Adapter, pszAGCTableFile,
> + CONFIG_BB_AGC_TAB) == _FAIL) {
...this and the other such changes below are just way ugly, whatever
the coding style says.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 4/7] staging: rtl8723bs: Move braces to same line as conditional Justin Vreeland <justin@jvreeland.com> - 2017-05-02 03:00 +0200
Re: [PATCH v2 4/7] staging: rtl8723bs: Move braces to same line as conditional Bastien Nocera <hadess@hadess.net> - 2017-05-04 14:00 +0200
Re: [PATCH v2 4/7] staging: rtl8723bs: Move braces to same line as conditional Justin Vreeland <justin@jvreeland.com> - 2017-05-06 00:10 +0200
Re: [PATCH v2 4/7] staging: rtl8723bs: Move braces to same line as conditional Justin Vreeland <justin@jvreeland.com> - 2017-05-06 00:20 +0200
Re: [PATCH v2 4/7] staging: rtl8723bs: Move braces to same line as conditional Bastien Nocera <hadess@hadess.net> - 2017-05-06 11:40 +0200
csiph-web