Re: [PATCH v1] vmbus: Reuse uuid_le_to_bin() helper

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1] vmbus: Reuse uuid_le_to_bin() helper
Date	2017-05-04 10:10 +0200
Message-ID	<tDjZL-MX-1@gated-at.bofh.it> (permalink)
References	<tD5WO-8gC-15@gated-at.bofh.it> <tD6g9-8nI-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, May 03, 2017 at 08:19:22PM +0300, Andy Shevchenko wrote:
> On Wed, 2017-05-03 at 20:07 +0300, Andy Shevchenko wrote:
> > Instead of open coded variant use generic helper to convert UUID
> > strings
> > to binary format.
> 
> > @@ -677,12 +644,14 @@ static ssize_t remove_id_store(struct
> > device_driver *driver, const char *buf,
> >  {
> >  	struct hv_driver *drv = drv_to_hv_drv(driver);
> >  	struct vmbus_dynid *dynid, *n;
> > 
> 
> > -	size_t retval = -ENODEV;
> > 
> > +	ssize_t retval;
> 
> Just noticed, I'm fixing a bug here as well.

It doesn't affect runtime.  You can store negatives in unsigned types so
long as they're uint or larger.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1] vmbus: Reuse uuid_le_to_bin() helper Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-03 19:10 +0200
  Re: [PATCH v1] vmbus: Reuse uuid_le_to_bin() helper Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-05-03 19:30 +0200
    Re: [PATCH v1] vmbus: Reuse uuid_le_to_bin() helper Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-04 10:10 +0200

csiph-web