Re: new warning at net/wireless/util.c:1236

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	"Coelho, Luciano" <luciano.coelho@intel.com>
Newsgroups	linux.kernel
Subject	Re: new warning at net/wireless/util.c:1236
Date	Thu, 04 May 2017 08:10:01 +0200
Message-ID	<tDi7D-83R-1@gated-at.bofh.it> (permalink)
References	<tDeGJ-5D9-1@gated-at.bofh.it> <tDgIy-6W9-7@gated-at.bofh.it>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.38,286,1491289200"; d="scan'208";a="95388197"
Thread-Topic	new warning at net/wireless/util.c:1236
Thread-Index	AQHSxJyLGJl/EYPjokyMY00NbO/tIg==
Accept-Language	en-US
Content-Language	en-US
X-Originating-IP	[10.252.19.243]
Content-Type	text/plain; charset="utf-8"
Content-ID	<28266EE120BE294D965460F0C60F93A0@intel.com>
Content-Transfer-Encoding	base64
MIME-Version	1.0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	29
Organization	linux.* mail to news gateway
X-Original-Cc	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>, "davem@davemloft.net" <davem@davemloft.net>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "johannes@sipsolutions.net" <johannes@sipsolutions.net>
X-Original-Date	Thu, 4 May 2017 06:06:18 +0000
X-Original-Message-ID	<1493877978.14233.85.camel@intel.com>
X-Original-References	<CA+55aFxyp5gpUZEYHXLwyhbK6DMWf4RoVykGxq9FPtO=j4yJsw@mail.gmail.com> <87o9v99r3g.fsf@purkki.adurom.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1635424

Show key headers only | View raw

On Thu, 2017-05-04 at 07:35 +0300, Kalle Valo wrote:
> Linus Torvalds <torvalds@linux-foundation.org> writes:
> 
> > So my Dell XPS 13 seems to have grown a new warning as of the
> > networking merge yesterday.
> > 
> > Things still work, but when it starts warning, it generates a *lot* of
> > noise (I got 36 of these within about ten minutes).
> > 
> > I have no idea what triggered it, because when I rebooted (not because
> > of this issue, but just to reboot into a newer kernel) I don't see it
> > again.
> > 
> > This is all pretty regular wireless - it's intel 8260 wireless in a
> > fairly normal laptop.
> > 
> > Things still seem to *work* ok, so the only problem here is the overly
> > verbose and useless WARN_ON. It doesn't even print out *which* rate it
> > is warning about, it just does that stupid unconditional WARN_ON()
> > without ever shutting up about it..
> > 
> > The WARN_ON() seems to be old, but my logs don't seem to have any
> > mention of this until today, so there's something that has changed
> > that now triggers it.
> > 
> > Ideas?
> > 
> >                   Linus
> > 
> > ---
> > 
> > WARNING: CPU: 3 PID: 1138 at net/wireless/util.c:1236
> > cfg80211_calculate_bitrate+0x139/0x170 [cfg80211]
> 
> As this is with iwlwifi adding also Luca. There were some rate handling
> changes in iwlwifi, like commit 77e409455f41, but don't know if that
> could cause this.

Thanks Kalle.  I don't see anything in the iwlwifi driver that could be
causing this.  Johannes suspects some RX rate changes he made in
mac80211...

--
Luca.

Thread

new warning at net/wireless/util.c:1236 Linus Torvalds <torvalds@linux-foundation.org> - 2017-05-04 04:30 +0200
  Re: new warning at net/wireless/util.c:1236 Kalle Valo <kvalo@codeaurora.org> - 2017-05-04 06:40 +0200
    Re: new warning at net/wireless/util.c:1236 "Coelho, Luciano" <luciano.coelho@intel.com> - 2017-05-04 08:10 +0200
  Re: new warning at net/wireless/util.c:1236 Johannes Berg <johannes@sipsolutions.net> - 2017-05-04 08:50 +0200

csiph-web