Re: [PATCHv2 1/2] Input: pwm-vibra: new driver

From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv2 1/2] Input: pwm-vibra: new driver
Date	2017-05-04 02:50 +0200
Message-ID	<tDd7X-4qj-5@gated-at.bofh.it> (permalink)
References	<tD0u5-4zo-3@gated-at.bofh.it> <tD0u6-4zo-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Sebastian Reichel <sebastian.reichel@collabora.co.uk> [170503 04:14]:
> Provide a simple driver for PWM controllable vibrators. It
> will be used by Motorola Droid 4.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> ---
> Changes since PATCHv1:
>  - move driver removal code to input->close function
>  - mark PM functions __maybe_unused and drop #ifdef CONFIG_PM_SLEEP
>  - remove duplicate NULL check for vibrator in probe function
>  - cancel work in suspend function

I'm getting this if CONFIG_INPUT_FF_MEMLESS is not selected:

ERROR: "input_ff_create_memless" [drivers/input/misc/pwm-vibra.ko] undefined!

Other than that works for me with your test app after
modprobe of pwm-omap-dmtimer and ff_memless:

Tested-by: Tony Lindgren <tony@atomide.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv2 0/2] PWM Vibrator driver Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-03 13:20 +0200
  [PATCHv2 1/2] Input: pwm-vibra: new driver Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-05-03 13:20 +0200
    Re: [PATCHv2 1/2] Input: pwm-vibra: new driver Tony Lindgren <tony@atomide.com> - 2017-05-04 02:50 +0200

csiph-web