Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1635336

Re: [GIT PULL] locking fixes

Show all headers | View raw

This is from last merge window, and the reason I react now is that
nobody noticed or cared until we had a release..

On Mon, Feb 27, 2017 at 11:57 PM, Ingo Molnar <mingo@kernel.org> wrote:
>
> Peter Zijlstra (1):
>       locking/refcounts: Out-of-line everything

This one is all good generally, but it has one really stupid side
effect: it makes refcounting GPL-only.

That's just silly. These are functions that atomically add and
subtract one. The only thing that making them GPL-only can possibly do
is to make people hack around it, and lose the overflow handling
debugging in the process.

It also breaks any kref uses. Which is what drivers etc are supposed to use.

So that "move from inline to out-of-line" had a big subtle semantic
change that was probably not intentional, and certainly not
documented.

                  Linus

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [GIT PULL] locking fixes Linus Torvalds <torvalds@linux-foundation.org> - 2017-05-04 01:30 +0200
  Re: [GIT PULL] locking fixes Peter Zijlstra <peterz@infradead.org> - 2017-05-04 07:50 +0200
    Re: [GIT PULL] locking fixes Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-05 00:50 +0200
      refcount: change EXPORT_SYMBOL markings Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-05-05 01:00 +0200

csiph-web