Re: [PATCH 1/2] dt/bindings: Add bindings for Broadcom STB DRAM Sensors

From	Markus Mayer <markus.mayer@broadcom.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] dt/bindings: Add bindings for Broadcom STB DRAM Sensors
Date	2017-05-04 00:30 +0200
Message-ID	<tDaWu-34r-7@gated-at.bofh.it> (permalink)
References	(1 earlier) <txHV8-29d-11@gated-at.bofh.it> <tAejU-o2-13@gated-at.bofh.it> <tAWkX-4nM-25@gated-at.bofh.it> <tAZCa-6zp-25@gated-at.bofh.it> <tAZLQ-6S4-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Rob,

On 27 April 2017 at 15:00, Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 04/27/2017 02:57 PM, Rob Herring wrote:
>>>>> +Optional properties:
>>>>> +  - cell-index: the index of the DPFE instance; will default to 0 if not set
>>
>> Don't use cell-index. It's not a valid property for FDT (only real
>> OpenFirmware).
>
> My bad, I was advising Markus to use this property since it was largely
> used throughout Documentation/devicetree/bindings/. What would be a more
> appropriate way to have the same information? Aliases?

Hopefully this will be the last time we need to pester you about this.
What should we be using instead of cell-index to identify multiple
instances of a device?

To give you an idea of what the code looks like right now:

ret = of_property_read_u32(dev->of_node, "cell-index", &index);
if (ret)
    index = 0;
[...]
dev_set_name(dpfe_dev, "dpfe%u", index);
ret = device_register(dpfe_dev);

Enumerating the devices like this is what we are after.

Thanks,
-Markus

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] dt/bindings: Add bindings for Broadcom STB DRAM Sensors Markus Mayer <markus.mayer@broadcom.com> - 2017-04-25 21:30 +0200
  Re: [PATCH 1/2] dt/bindings: Add bindings for Broadcom STB DRAM Sensors Markus Mayer <markus.mayer@broadcom.com> - 2017-04-27 20:30 +0200
    Re: [PATCH 1/2] dt/bindings: Add bindings for Broadcom STB DRAM  Sensors Rob Herring <robh@kernel.org> - 2017-04-28 00:00 +0200
      Re: [PATCH 1/2] dt/bindings: Add bindings for Broadcom STB DRAM  Sensors Florian Fainelli <f.fainelli@gmail.com> - 2017-04-28 00:10 +0200
        Re: [PATCH 1/2] dt/bindings: Add bindings for Broadcom STB DRAM Sensors Markus Mayer <markus.mayer@broadcom.com> - 2017-05-04 00:30 +0200

csiph-web